Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[warm-reboot] Remove warmboot file path that overrides the default path #6198

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

shi-su
Copy link
Contributor

@shi-su shi-su commented Dec 13, 2020

- Why I did it
The sai.profile file in kvm images overrides the warmboot file with path /var/cache/sai_warmboot.bin. Since the directory /var/cache is not mounted in syncd, it will be cleared in an image upgrade, the warm-reboot image upgrade will fail if the file is put in the directory.

Fix #6183

- How I did it
Remove the path that overrides the default path. The warmboot file path will then be the default value /var/warmboot/sai-warmboot.bin. Since /var/warmboot/ is mounted by /host/warmboot/ in the host, it could survive an image upgrade.

- How to verify it
Tested warm reboot upgrading kvm image locally.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@kcudnik
Copy link
Contributor

kcudnik commented Dec 13, 2020

@shi-su @lguohan Just to clarify, if we have right now in production image running this profile, it will write on warm shutdown to /var/cache but new image with this PR will not pick up that file, since it will use default value which is "/var/warmboot/sai-warmboot.bin"

from the other hand, i see that this changes are only for VS ?

@shi-su
Copy link
Contributor Author

shi-su commented Dec 13, 2020

@shi-su @lguohan Just to clarify, if we have right now in production image running this profile, it will write on warm shutdown to /var/cache but new image with this PR will not pick up that file, since it will use default value which is "/var/warmboot/sai-warmboot.bin"

from the other hand, i see that this changes are only for VS ?

I only found this profile for VS, real devices should just use the default path. So devices in production should not be affected.

@shi-su shi-su merged commit 9580b04 into sonic-net:master Dec 14, 2020
lguohan pushed a commit that referenced this pull request Dec 14, 2020
…fault path (#6201)

This PR adds the changes in #6198 to 201811 branch to support warm-reboot image upgrade for kvm images.

The sai.profile file in kvm images overrides the warmboot file with path /var/cache/sai_warmboot.bin. Since the directory /var/cache is not mounted in syncd, it will be cleared in an image upgrade, the warm-reboot image upgrade will fail if the file is put in the directory.

Remove the path that overrides the default path. The warmboot file path will then be the default value /var/warmboot/sai-warmboot.bin. Since /var/warmboot/ is mounted by /host/warmboot/ in the host, it could survive an image upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orchagent crash in warm-reboot upgrade between master kvm images
4 participants