Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Barefoot]: fix unresolved SFP type on Newport/Montara #6063

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

dmytroxshevchuk
Copy link
Contributor

@dmytroxshevchuk dmytroxshevchuk commented Nov 30, 2020

- Why I did it
show interface status and sfpshow eeprom commands show not correct information about sfp status.
show interface status command result:

admin@sonic:~$ show interfaces status
  Interface            Lanes    Speed    MTU    FEC        Alias    Vlan    Oper    Admin             Type    Asym PFC
-----------  ---------------  -------  -----  -----  -----------  ------  ------  -------  ---------------  ----------
  Ethernet0          0,1,2,3     100G   9100    N/A    Ethernet0  routed    down       up              N/A         N/A
  Ethernet8        8,9,10,11     100G   9100    N/A    Ethernet8  routed    down       up  QSFP28 or later         N/A
 Ethernet16      16,17,18,19     100G   9100    N/A   Ethernet16  routed    down       up  QSFP28 or later         N/A
 Ethernet24      24,25,26,27     100G   9100    N/A   Ethernet24  routed    down       up  QSFP28 or later         N/A

For example sfpshow eeprom show something like this:

admin@sonic:~$ sfpshow eeprom
Ethernet0: SFP EEPROM Not detected

Ethernet8: SFP EEPROM detected
...

Also command sfpshow presence show Not present for Ethernet0

admin@sonic:~$ sfpshow presence
Port         Presence
-----------  -----------
Ethernet0    Not present
Ethernet8    Present
Ethernet16   Present

- How I did it

- How to verify it
After fix must be correct SFP status in show interface status command.
Before:

admin@sonic:~$ show interfaces status
  Interface            Lanes    Speed    MTU    FEC        Alias    Vlan    Oper    Admin             Type    Asym PFC
-----------  ---------------  -------  -----  -----  -----------  ------  ------  -------  ---------------  ----------
  Ethernet0          0,1,2,3     100G   9100    N/A    Ethernet0  routed    down       up              N/A         N/A
  Ethernet8        8,9,10,11     100G   9100    N/A    Ethernet8  routed    down       up  QSFP28 or later         N/A
 Ethernet16      16,17,18,19     100G   9100    N/A   Ethernet16  routed    down       up  QSFP28 or later         N/A
 Ethernet24      24,25,26,27     100G   9100    N/A   Ethernet24  routed    down       up  QSFP28 or later         N/A

After:

admin@sonic:~$ show interfaces status
  Interface            Lanes    Speed    MTU    FEC        Alias    Vlan    Oper    Admin             Type    Asym PFC
-----------  ---------------  -------  -----  -----  -----------  ------  ------  -------  ---------------  ----------
  Ethernet0          0,1,2,3     100G   9100    N/A    Ethernet0  routed    down       up  QSFP28 or later         N/A
  Ethernet8        8,9,10,11     100G   9100    N/A    Ethernet8  routed    down       up  QSFP28 or later         N/A
 Ethernet16      16,17,18,19     100G   9100    N/A   Ethernet16  routed    down       up  QSFP28 or later         N/A
 Ethernet24      24,25,26,27     100G   9100    N/A   Ethernet24  routed    down       up  QSFP28 or later         N/A

Also must be resolved sfpshow eeprom and sfpshow presence commands.

admin@sonic:~$ sfpshow presence
Port         Presence
-----------  ----------
Ethernet0    Present
Ethernet8    Present
Ethernet16   Present

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@dmytroxshevchuk dmytroxshevchuk changed the title [sfp]: fix unresolved type on Newport/Montara [sfp]: fix unresolved sfp type on Newport/Montara Nov 30, 2020
@dmytroxshevchuk dmytroxshevchuk changed the title [sfp]: fix unresolved sfp type on Newport/Montara [platform]: fix unresolved sfp type on Newport/Montara Nov 30, 2020
@akokhan
Copy link
Contributor

akokhan commented Dec 1, 2020

retest vsimage please

@dmytroxshevchuk dmytroxshevchuk force-pushed the fix_sfp_type_on_newport branch from da63e52 to 682379e Compare December 1, 2020 13:43
@jleveque
Copy link
Contributor

jleveque commented Dec 2, 2020

@akokhan: Please review.

@akokhan
Copy link
Contributor

akokhan commented Dec 2, 2020

@vboykox , please take a look

@vboykox
Copy link
Member

vboykox commented Dec 2, 2020

Approved.

@jleveque
Copy link
Contributor

jleveque commented Dec 2, 2020

@dmytroxshevchuk: Can you please add a brief description for this PR?

@dmytroxshevchuk
Copy link
Contributor Author

dmytroxshevchuk commented Dec 4, 2020

@dmytroxshevchuk: Can you please add a brief description for this PR?

done
@jleveque please check

@jleveque jleveque changed the title [platform]: fix unresolved sfp type on Newport/Montara [Barefoot]: fix unresolved SFP type on Newport/Montara Dec 4, 2020
@jleveque jleveque merged commit 026f0ec into sonic-net:master Dec 4, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
Fix `show interface status` and `sfpshow eeprom` commands showing incorrect information on Newport/Montara platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants