-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Barefoot]: fix unresolved SFP type on Newport/Montara #6063
Merged
jleveque
merged 1 commit into
sonic-net:master
from
dmytroxshevchuk:fix_sfp_type_on_newport
Dec 4, 2020
Merged
[Barefoot]: fix unresolved SFP type on Newport/Montara #6063
jleveque
merged 1 commit into
sonic-net:master
from
dmytroxshevchuk:fix_sfp_type_on_newport
Dec 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytroxshevchuk
changed the title
[sfp]: fix unresolved type on Newport/Montara
[sfp]: fix unresolved sfp type on Newport/Montara
Nov 30, 2020
dmytroxshevchuk
changed the title
[sfp]: fix unresolved sfp type on Newport/Montara
[platform]: fix unresolved sfp type on Newport/Montara
Nov 30, 2020
3 tasks
retest vsimage please |
dmytroxshevchuk
force-pushed
the
fix_sfp_type_on_newport
branch
from
December 1, 2020 13:43
da63e52
to
682379e
Compare
dmytroxshevchuk
force-pushed
the
fix_sfp_type_on_newport
branch
from
December 1, 2020 17:02
682379e
to
c9c675e
Compare
@akokhan: Please review. |
@vboykox , please take a look |
akokhan
approved these changes
Dec 2, 2020
Approved. |
vboykox
approved these changes
Dec 2, 2020
vboykox
approved these changes
Dec 2, 2020
jleveque
approved these changes
Dec 2, 2020
@dmytroxshevchuk: Can you please add a brief description for this PR? |
done |
jleveque
changed the title
[platform]: fix unresolved sfp type on Newport/Montara
[Barefoot]: fix unresolved SFP type on Newport/Montara
Dec 4, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
Fix `show interface status` and `sfpshow eeprom` commands showing incorrect information on Newport/Montara platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
show interface status
andsfpshow eeprom
commands show not correct information about sfp status.show interface status
command result:For example
sfpshow eeprom
show something like this:Also command
sfpshow presence
showNot present
for Ethernet0- How I did it
- How to verify it
After fix must be correct SFP status in
show interface status
command.Before:
After:
Also must be resolved
sfpshow eeprom
andsfpshow presence
commands.- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)