[Celestica] Fix issues where the part of udev rule are not working as expect

[sandycelestica]

- Why I did it
Some udev scripts has no execute permission under admin which cause the cosutil could not get the prefix.
- How I did it
chmod the permission of popmsg.sh and udev_prefix.sh

- How to verify it
consutil show can show the port list as you rename them

- Which release branch to backport (provide reason below if selected)
master

- Description for the changelog
Change the platform-modules-haliburton.postinst.Add below:
sudo chmod +x /usr/local/bin/udev_prefix.sh
sudo chmod +x /usr/local/bin/popmsg.sh

- Test log as below
admin@sonic:$ ls
mytty.json
platform-modules-haliburton_0.9_amd64.deb
platform-modules-haliburton_1.0_amd64.deb
admin@sonic:$ cd /usr/local/bin/
admin@sonic:/usr/local/bin$ ls -l *.sh
-rwxr-xr-x 1 root staff 2054 Jul 31 2020 finalize-warmboot.sh
-rwxr-xr-x 1 root staff 162 Jul 31 2020 host-ssh-keygen.sh
-rwxr-xr-x 1 root root 963 Jan 28 03:45 platform_api_mgnt.sh
-rw-r--r-- 1 root root 227 Aug 17 2018 popmsg.sh
-rwxr-xr-x 1 root staff 6240 Jul 31 2020 swss.sh
-rwxr-xr-x 1 root staff 5981 Jul 31 2020 syncd.sh
-rw-r--r-- 1 root root 485 Aug 17 2018 udev_prefix.sh
admin@sonic:/usr/local/bin$ cd ~
admin@sonic:$
admin@sonic:$ sudo dpkg -i platform-modules-haliburton_1.0_amd64.deb
(Reading database ... 27246 files and directories currently installed.)
Preparing to unpack platform-modules-haliburton_1.0_amd64.deb ...
Unpacking platform-modules-haliburton (1.0) over (0.9) ...
Setting up platform-modules-haliburton (1.0) ...
Synchronizing state of platform-modules-haliburton.service with SysV service script with /lib/systemd/systemd-sysv-install.
........
admin@sonic:$
admin@sonic:$ cd /usr/local/bin/
admin@sonic:/usr/local/bin$ ls -l *.sh
-rwxr-xr-x 1 root staff 2054 Jul 31 2020 finalize-warmboot.sh
-rwxr-xr-x 1 root staff 162 Jul 31 2020 host-ssh-keygen.sh
-rwxr-xr-x 1 root root 963 Jan 28 03:45 platform_api_mgnt.sh
-rwxr-xr-x 1 root root 227 Jan 28 03:45 popmsg.sh
-rwxr-xr-x 1 root staff 6240 Jul 31 2020 swss.sh
-rwxr-xr-x 1 root staff 5981 Jul 31 2020 syncd.sh
-rwxr-xr-x 1 root root 485 Jan 28 03:45 udev_prefix.sh

[Blueve]

Seems like you are working on a old commit. You can run following commands to fix it:

git fetch origin
git reset --hard 148436d42e4e8371e374af39001b3a8a38bd5b0c
git cherry-pick 128a0968ae713d045f99b66014620b9c54ec84b5

[Blueve]

Please update your PR with previous comments

[sandycelestica]

Please update your PR with previous comments

Hi ,
I forked a new branch for my repository and would submit PR again.
And I found that the 50-ttyUSB-C0.rules also need to be updated(This must be a mistake I made before. ). There is an issue for port 13 to port 48 when these ports lost it would not popout messages. Could I update it?

Could I commit these two files in one time?

[Blueve]

Sure, looks good to me : )
Could you also update the PR description? Then we can know what the extra fix is.
And you can also change the PR title to "[Celestica] Fix issues where the part of udev rule are not working as expect"
I will approve this after you updated the title and description, thanks!

Please update your PR with previous comments

Hi ,
I forked a new branch for my repository and would submit PR again.
And I found that the 50-ttyUSB-C0.rules also need to be updated(This must be a mistake I made before. ). There is an issue for port 13 to port 48 when these ports lost it would not popout messages. Could I update it?

Could I commit these two files in one time?

[sandycelestica]

Mainly changes two files.
Update 50-ttyUSB-C0.rules for port 13 to 48 would not pop out left msg when been disconnected.
Update platform-modules-haliburton.postinst to grant the execute permission of prefix generate file.

[sandycelestica]

Could please help to review : #6039. If any comments please let me know. Thanks.

…

On Fri, Nov 27, 2020 at 10:24 AM Blueve ***@***.***> wrote: Sure, looks good to me : ) Could you also update the PR description? Then we can know what the extra fix is. And you can also change the PR title to "[Celestica] Fix issues where the part of udev rule are not working as expect" I will approve this after you updated the title and description, thanks! Please update your PR with previous comments Hi , I forked a new branch for my repository and would submit PR again. And I found that the 50-ttyUSB-C0.rules also need to be updated(This must be a mistake I made before. ). There is an issue for port 13 to port 48 when these ports lost it would not popout messages. Could I update it? Could I commit these two files in one time? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6039 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLLGDRLJ4GW7Y7YJQ47U5DSR4EU7ANCNFSM4UCSFY7A> .

-- Thanks and Regards. Sandy Li Software Design Engineering Specialist,GDS SSL Mobile: +86 <+86%20136%201189%204667>18073112486 Email: *[email protected] <[email protected]>* www.celestica.com Think Bigger, Reach Further

[Blueve]

retest vsimage please

[Blueve]

retest vsimage please