[frr] remove FRR rsyslog file outchannel #5962
Conversation
SONiC runs FRR inside a docker, the logs are captured in base image. Leaving file outchannel inside docker will generate log file inside the docker and take harddrive space unnecessarily. Signed-off-by: Ying Xie <[email protected]>
yxieca
changed the title
|
This may be suited for a future PR, but now that we are using FRR instead of quagga, the path |
|
@yxieca - would you like to file an issue? Thanks. |
|
@yxieca There is a dependency on this FRR log file for the functionality of bgpmon that is running inside the BGP docker. |
|
Closing this PR due to bgpmon issue Gen-Hwa identified. Putting back the original change in #5966 |
|
i am confused on which approach we are taking now? |
According to Gen-Hwa/Judy/Arvind, we are taking this approach because bgpmon can work without tapping into the log. Judy will make a follow up change to make sure multi-ASIC frr logs are captured and put into /var/log/quagga/bgpd.log with name space tag. |
- Why I did it frr is creating /var/log/frr/frr.log inside the frr docker and letting it grow. It will eventually exhaust hard drive space. To fixe issue #5965 - How I did it Remove rsyslog file outchannel so that frr won't generate /var/log/frr/frr.log inside the docker. - How to verify it Manually removed the outchannel and restart BGP docker, making sure that /var/log/frr/frr.log is no longer created inside the docker. While restarting bgp docker, observed that base image /var/log/quagga/bgpd.log continued to grow and captured all FRR logs.
- Why I did it frr is creating /var/log/frr/frr.log inside the frr docker and letting it grow. It will eventually exhaust hard drive space. To fixe issue sonic-net#5965 - How I did it Remove rsyslog file outchannel so that frr won't generate /var/log/frr/frr.log inside the docker. - How to verify it Manually removed the outchannel and restart BGP docker, making sure that /var/log/frr/frr.log is no longer created inside the docker. While restarting bgp docker, observed that base image /var/log/quagga/bgpd.log continued to grow and captured all FRR logs.
- Why I did it
frr is creating /var/log/frr/frr.log inside the frr docker and letting it grow. It will eventually exhaust hard drive space.
To fixe issue #5965
- How I did it
Remove rsyslog file outchannel so that frr won't generate /var/log/frr/frr.log inside the docker.
- How to verify it
Manually removed the outchannel and restart BGP docker, making sure that /var/log/frr/frr.log is no longer created inside the docker.
While restarting bgp docker, observed that base image /var/log/quagga/bgpd.log continued to grow and captured all FRR logs.
- Which release branch to backport (provide reason below if selected)
Signed-off-by: Ying Xie [email protected]