[DellEMC]: EEPROM platform API Python3 compliance changes #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 1b5159f into 2fe79c2 - view on LGTM.com fixed alerts:
|
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
jleveque
approved these changes
Nov 25, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…5960) Make EEPROM platform APIs Python3 compliant in DellEMC platforms by handling bytearray type returned by read_eeprom and read_eeprom_bytes methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Make EEPROM platform APIs Python3 compliant in DellEMC platforms.
- How I did it
Handle
bytearraytype returned byread_eepromandread_eeprom_bytesmethods.- How to verify it
Wrote a python script to load Chassis class and then call the APIs accordingly.
Logs: UT_logs.txt
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
[DellEMC]: EEPROM platform API Python3 compliance changes
- A picture of a cute animal (not mandatory but encouraged)