-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic_debian_extension] install docker_image_ctl.j2 template in the … #5937
Merged
lguohan
merged 1 commit into
sonic-net:master
from
stepanblyschak:include_docker_template
Feb 25, 2021
Merged
[sonic_debian_extension] install docker_image_ctl.j2 template in the … #5937
lguohan
merged 1 commit into
sonic-net:master
from
stepanblyschak:include_docker_template
Feb 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…image templates Signed-off-by: Stepan Blyshchak <[email protected]>
stepanblyschak
changed the title
[sonic_debian_exntesion] install docker_image_ctl.j2 template in the …
[sonic_debian_extension] install docker_image_ctl.j2 template in the …
Dec 15, 2020
rajendra-dendukuri
approved these changes
Jan 15, 2021
/AzurePipelines run |
Commenter does not have sufficient privileges for PR 5937 in repo Azure/sonic-buildimage |
renukamanavalan
approved these changes
Jan 30, 2021
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
retest vsimage please |
1 similar comment
retest vsimage please |
retest vsimage please. |
retest vsimage please |
1 similar comment
retest vsimage please |
/Azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/Azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Note: I have restarted the pipelines but the tests are not really restarted. Any way to do so? |
lguohan
approved these changes
Feb 25, 2021
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…image templates (sonic-net#5937) SONiC Package Manager will require to auto-generate the start script using that template. For that, we need this template to be recorded in SONiC filesystem. Signed-off-by: Stepan Blyshchak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…image templates
Signed-off-by: Stepan Blyshchak [email protected]
This PR is part of SONiC Application Extension
- Why I did it
SONiC Package Manager will require to auto-generate the start script using that template. For that, we need this template to be recorded in SONiC filesystem.
- How I did it
Copy the template in SONiC filesystem during image build.
- How to verify it
Build an image and cat /usr/share/sonic/templates/docker_image_ctl.j2.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)