Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reboot-history] Add reboot history to state db #5933

Merged
merged 5 commits into from
Nov 21, 2020
Merged

[reboot-history] Add reboot history to state db #5933

merged 5 commits into from
Nov 21, 2020

Conversation

sujinmkang
Copy link
Collaborator

- Why I did it
Add reboot history to State db so that can be used telemetry service
- How I did it
Split the process-reboot-cause service to determine-reboot-cause and process-reboot-cause
determine-reboot-cause to determine the reboot cause
process-reboot-cause to parse the reboot cause files and put the reboot history to state db
Moved to sonic-host-service* packages
- How to verify it
Performed unit test and tested on DUT
- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@sujinmkang sujinmkang requested a review from jleveque November 16, 2020 18:25
@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2020

This pull request introduces 3 alerts and fixes 1 when merging c607ca0 into 67dbbb3 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2020

This pull request introduces 3 alerts and fixes 1 when merging 43e0bd3 into 3be3f4d - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Nov 19, 2020

This pull request introduces 1 alert and fixes 1 when merging 0bdfb29 into 0a9d7a2 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@sujinmkang
Copy link
Collaborator Author

retest vsimage please

src/sonic-host-services/scripts/process-reboot-cause Outdated Show resolved Hide resolved
src/sonic-host-services/scripts/process-reboot-cause Outdated Show resolved Hide resolved
src/sonic-host-services/setup.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Nov 20, 2020

This pull request introduces 1 alert and fixes 1 when merging 3093d0f into d2f143d - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix LGTM alert.

@lgtm-com
Copy link

lgtm-com bot commented Nov 20, 2020

This pull request fixes 1 alert when merging 4c89f8a into d2f143d - view on LGTM.com

fixed alerts:

  • 1 for Variable defined multiple times

@sujinmkang
Copy link
Collaborator Author

retest vsimage please

@sujinmkang sujinmkang merged commit 5b31996 into sonic-net:master Nov 21, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
- Why I did it
Add reboot history to State db so that can be used telemetry service
- How I did it
Split the process-reboot-cause service to determine-reboot-cause and process-reboot-cause
determine-reboot-cause to determine the reboot cause
process-reboot-cause to parse the reboot cause files and put the reboot history to state db
Moved to sonic-host-service* packages
- How to verify it
Performed unit test and tested on DUT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants