Fix docker images rebuilt issue when building each host image #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest mellanox please |
yxieca
previously approved these changes
Nov 15, 2020
qiluo-msft
reviewed
Nov 16, 2020
|
@Kalimuthu-Velappan Could you help review? |
|
retest broadcom please |
qiluo-msft
approved these changes
Nov 24, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…net#5925) * Change back the mtime changed by applying patch * Fix bug * Fix bug * Use the grep or pattern instead to call a new grep command
ouxlwhu
reviewed
Feb 10, 2023
| @$$(file >[email protected],$$($$*_DEP_FILES)) | ||
| @cat [email protected] |xargs git hash-object >[email protected] | ||
| @if ! cmp -s [email protected] [email protected]; then cp [email protected] $$@; cp [email protected] [email protected]; fi | ||
| @rm -f [email protected] [email protected] |
There was a problem hiding this comment.
I find an issue that if I modify a file in a submodule, the corresponding packages could not be rebuilt. Eg, src/sonic-swss/cfgmgr/portmgr.cpp is modified，and make swss.deb will not be rebuilt, only swss.smdep and swss.smdep.smsha update, swss.dep is not touched, so target of swss.deb will not be executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
The docker images rebuilt when building each host image in nightly build, it is not as expect.
It is caused by some of source files touched during building images, such as applying patches to source folders.
- How I did it
Before the .dep.sha files generated, check if the hash values changed, if the content is exactly the same as the old one, not necessary to touch the it.
- How to verify it
make SONIC_DPKG_CACHE_METHOD=wcache SONIC_DPKG_CACHE_SOURCE=/cache target/sonic-broadcom.bin
make SONIC_DPKG_CACHE_METHOD=wcache SONIC_DPKG_CACHE_SOURCE=/cache target/sonic-aboot-broadcom.swi
No docker images rebuilt
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)