Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-asic] Updated teamdctl bash script to support for multi-asic #5851

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Nov 7, 2020

What I did:
Enhanced teamdctl bash script to work for Multi-asic. Added option -n [0 to n] (asic number).
Changes are similar to other scripts swssloglevel/bcmcmd that has multi-asic support.

Why I did:
Some of sonic-mgmt test case (test_lag_2.py) uses teamdctl command from test script.

How I Verify:
Usage: /usr/bin/teamdctl -n [0 to n] [OPTION]...

Single ASIC:

teamdctl PortChannel0002 state
setup:
  runner: lacp
ports:
  Ethernet0
    link watches:
      link summary: up

Multi ASIC

teamdctl -n 0 PortChannel0002 state
setup:
  runner: lacp
ports:
  Ethernet0
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0
    runner:
      aggregator ID: 139, Selected
      selected: yes
      state: current
  Ethernet4
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0
    runner:
      aggregator ID: 139, Selected
      selected: yes
      state: current
runner:
  active: yes
  fast rate: no

Copy link
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdosi abdosi merged commit 84aa99d into sonic-net:master Nov 9, 2020
@abdosi abdosi deleted the teamdctl branch November 9, 2020 20:31
abdosi added a commit that referenced this pull request Nov 9, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants