[multi-asic] Enhanced the getMount() API and docker mount point check #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platforms. Signed-off-by: Abhishek Dosi <[email protected]>
|
retest broadcom please |
1 similar comment
|
retest broadcom please |
|
@SuvarnaMeenakshi Please review this. |
SuvarnaMeenakshi
approved these changes
Nov 9, 2020
abdosi
added a commit
that referenced
this pull request
Nov 9, 2020
API getMount() API was not updated to handle multi-asic platforms Updated API getMount() to return abspath() for Docker Mount Point and use that one for mount point comparison Signed-off-by: Abhishek Dosi <[email protected]>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…-net#5848) API getMount() API was not updated to handle multi-asic platforms Updated API getMount() to return abspath() for Docker Mount Point and use that one for mount point comparison Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did:
API getMount() API was not updated to handle multi-asic platforms
because of which mount point comparison always return FALSE
and we were always creating new container image when doing config load_minigraph/reload/reboot.
How I did:
Updated API getMount() to return abspath() for Docker Mount Point
and use that one for mount point comparison
How I Verify:
Verify on Single ASIC platforms behavior is same as present
Verify on Multi-asic platforms we do not create new container when doing config load_minigraph/reload/reboot.
Also sonic-mgmt copp test were failing on Multi-asic platform
since test case update copp.json in swss docker and restart docker but that
change did not took impact since we were creating new container.
After this changes test case is working fine