[sflow] Clean-up sFlow container and port_index_mapper.py script #5846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix some spelling error and add addition check in port_index_mapper.py script. * Remove unneeded pyroute2 python module from sFlow container Signed-off-by: Garrick He <[email protected]>
|
@padmanarayana: Please review. |
padmanarayana
approved these changes
Nov 6, 2020
prsunny
approved these changes
Nov 6, 2020
|
Retest vsimage please |
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…ic-net#5846) * Fix some spelling error and add addition check in port_index_mapper.py script. * Remove unneeded pyroute2 python module from sFlow container Signed-off-by: Garrick He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script.
Signed-off-by: Garrick He [email protected]
- Why I did it
This PR just addresses some minor spelling issue in the port_index_mapper.py script and removes an unneeded module.
- How I did it
Update a 2 files
- How to verify it
Check the stateDB to ensure PORT_INDEX_TABLE is created and ensure the pyroute2 module is not installed.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
script.