Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mellanox] SN4410 support #5778

Merged
merged 11 commits into from
Nov 24, 2020
Merged

[Mellanox] SN4410 support #5778

merged 11 commits into from
Nov 24, 2020

Conversation

vadymhlushko-mlnx
Copy link
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Nov 2, 2020 •
edited
Loading

Signed-off-by: Vadym Hlushko [email protected]

- Why I did it

Add support for Mellanox Spectrum-3 based 100GbE/400GbE 1U. 24 QSFP-DD28 and 8 QSFP-DD ports

- How I did it

Added all config files that are needed to support SN4410.

- How to verify it

Need to check:

  • if there are no errors in logs via serial connection
  • if there are no errors in logs via ssh connection
  • interfaces creation
  • basic switching
  • basic routing

- Which release branch to backport (provide reason below if selected)

  • 201911
  • master

- Description for the changelog

Added files like for other platforms (e.g. SN4700) under - sonic-buildimage/device/mellanox/x86_64-mlnx_msn4410-r0 directory.

@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2020

This pull request introduces 5 alerts when merging 6d660d504becf3d8d26d4c29ed5a6df3dcd62377 into 1be9c4a - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Testing equality to None
  • 1 for Unused import
  • 1 for Unreachable code

@vadymhlushko-mlnx
Copy link
Contributor Author

retest this please

@volodymyrsamotiy
Copy link
Collaborator

Should be merged after #5767 is merged to master

@keboliu
Copy link
Collaborator

keboliu commented Nov 4, 2020

retest this please

@lguohan
Copy link
Collaborator

lguohan commented Nov 6, 2020

retest baseimage please

@liat-grozovik
Copy link
Collaborator

@vadymhlushko-mlnx please handle LGTM issues

@liat-grozovik
Copy link
Collaborator

retest mellanox please

@lguohan lguohan requested a review from jleveque November 16, 2020 12:27
@lguohan
Copy link
Collaborator

lguohan commented Nov 16, 2020

any missing data we need for a platform?

@liat-grozovik
Copy link
Collaborator

any missing data we need for a platform?

all should be there but I didnt merge as sonic-mgmt is not fully updated. so waiting for this PR to be available first and then we can merge both.

liat-grozovik
liat-grozovik requested changes Nov 16, 2020
View reviewed changes
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing pcied file

@vadymhlushko-mlnx
[SN4410] added symlinks to common files from SN4700 directory
d322d02 
Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
[SN4410] adapted to SN4410 - 'sai.profile' and 'sai_4700.xml' files f…
7192206 
…rom SN4700 directory

Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
[SN4410] adatped to SN4410 - 'sfputil.py' file from SN4700 directory
56dbdc6 
Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
[SN4410] added symlink to 'sensors.conf' file
f694dc3 
Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
[SN4410] added 'default_sku' file
53d2ee5 
Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
[SN4410] added 'platform_components.json' file
e9579f9 
Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
[SN4410] fixed symlinks to 'buffers_defaults_t*' files
b71adf3 
Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
[Mellanox] Added support for SN4410 platform - chassis.py, device_dat…
d365566 
…a.py, psu.py, thermal.py

Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
[SN4410] fixed LGTM alerts
cbac4ad 
Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
Copy link
Contributor Author

retest vsimage please

1 similar comment
@vadymhlushko-mlnx
Copy link
Contributor Author

retest vsimage please

liat-grozovik
liat-grozovik reviewed Nov 22, 2020
View reviewed changes
platform/mellanox/mlnx-platform-api/sonic_platform/thermal.py Outdated
@@ -269,6 +269,22 @@
]
)
},
# 4410
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadymhlushko-mlnx why this one was added in the middle and not on the end?
BTW, this list is only for non-default systems? i dont see sn4700 and i wonder if this should be added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will commit this change to the end.

SN4700 was already added - thermal.py please check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@liat-grozovik
Copy link
Collaborator

@vadymhlushko-mlnx please provide the reference to the sonic-mgmt with the sensor test.

@vadymhlushko-mlnx
Copy link
Contributor Author

@vadymhlushko-mlnx please provide the reference to the sonic-mgmt with the sensor test.

@liat-grozovik could you please clarify - what should I provide?

@liat-grozovik
Copy link
Collaborator

@jleveque any further comment? let me know if i missed a file :-)

jleveque
jleveque approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jleveque jleveque merged commit 5038730 into sonic-net:master Nov 24, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@vadymhlushko-mlnx @santhosh-kt
[Mellanox] SN4410 support (sonic-net#5778)
603bdf7 
Add support for Mellanox Spectrum-3 based 100GbE/400GbE 1U. 24 QSFP-DD28 and 8 QSFP-DD ports

Signed-off-by: Vadym Hlushko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
Enhancement ➕ Platform: Mellanox
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vadymhlushko-mlnx @volodymyrsamotiy @keboliu @lguohan @liat-grozovik @jleveque