dockers/docker-sonic-mgmt/Dockerfile.js: Add keysight ixnetwork-open-… #5762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…traffic-generator pypi package * pip install of ixnetwork-open-traffic-generator pypi package version 0.0.29 for open-traffic-generator based tests Signed-off-by: [email protected]
There was a problem hiding this comment.
@yxieca @neethajohn @baiwei0427 please review this PR. Thanks.
|
@baiwei0427 , can you check if the testcases work with this version? |
|
@baiwei0427 @neethajohn from thisl1_oneHundredGbe = OneHundredGbe(link_training=True,
ieee_media_defaults=False,
auto_negotiate=False,
speed='one_hundred_gbps',
flow_control=flow_ctl,
rs_fec=True)
common_l1_config = Layer1(name='common L1 config',
choice=l1_oneHundredGbe,
port_names=[tx.name, rx.name])to thisIndividual speed containers have been removed and speed is now an enum on the Layer1 class. auto_negotiation = AutoNegotiation(link_training=True,
rs_fec=True)
common_l1_config = Layer1(name='common L1 config',
speed='speed_100_gbps',
auto_negotiate=False,
auto_negotiation=auto_negotiation,
flow_control=flow_ctl,
port_names=[tx.name, rx.name]) |
baiwei0427
approved these changes
Nov 6, 2020
|
Hi @neethajohn, @baiwei0427 has tested the package using both 40G and 100G links and indicated that you would merge the PR? |
neethajohn
approved these changes
Nov 6, 2020
|
retest this please |
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
sonic-net#5762) *Why I did it Provide access to the ixnetwork-open-traffic-generator pypi package *How I did it Added a pip install entry for the package in the Dockerfile.j2 *How to verify it pip show ixnetwork-open-traffic-generator *Description for the changelog Install of ixnetwork-open-traffic-generator pypi package is required for proposed rdma tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Why I did it
Provide access to the ixnetwork-open-traffic-generator pypi package
*How I did it
Added a pip install entry for the package in the Dockerfile.j2
*How to verify it
pip show ixnetwork-open-traffic-generator
*Which release branch to backport (provide reason below if selected)
N/A
*Description for the changelog
Install of ixnetwork-open-traffic-generator pypi package is required for proposed rdma tests.
- A picture of a cute animal (not mandatory but encouraged)