[multi-ASIC] util changes with the BGP_INTERNAL_NEIGHBOR table. #5760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
| {# set the bgp neighbor timers if they have not default values #} | ||
| {% if (bgp_session['keepalive'] is defined and bgp_session['keepalive'] | int != 60) | ||
| or (bgp_session['holdtime'] is defined and bgp_session['holdtime'] | int != 180) %} | ||
| neighbor {{ neighbor_addr }} timers {{ bgp_session['keepalive'] | default("60") }} {{ bgp_session['holdtime'] | default("180") }} |
There was a problem hiding this comment.
I would suggest to use minimal timers here. We expect this sessions are live 100% of time
This is because these are internal sessions which will allways be up.
pavel-shirshov
approved these changes
Nov 5, 2020
arlakshm
approved these changes
Nov 5, 2020
|
retest vs please |
judyjoseph
added a commit
to judyjoseph/sonic-buildimage
that referenced
this pull request
Nov 10, 2020
…c-net#5760) - Why I did it Update the routine is_bgp_session_internal() by checking the BGP_INTERNAL_NEIGHBOR table. Additionally to address the review comment sonic-net#5520 (comment) Add timer settings as will in the internal session templates and keep it minimal as these sessions which will always be up. Updates to the internal tests data + add all of it to template tests. - How I did it Updated the APIs and the template files. - How to verify it Verified the internal BGP sessions are displayed correctly with show commands with this API is_bgp_session_internal()
3 tasks
judyjoseph
added a commit
that referenced
this pull request
Nov 10, 2020
Reintroduce #5760, along with the fix needed in the template file for python3 compatibility.
abdosi
pushed a commit
that referenced
this pull request
Nov 10, 2020
- Why I did it Update the routine is_bgp_session_internal() by checking the BGP_INTERNAL_NEIGHBOR table. Additionally to address the review comment #5520 (comment) Add timer settings as will in the internal session templates and keep it minimal as these sessions which will always be up. Updates to the internal tests data + add all of it to template tests. - How I did it Updated the APIs and the template files. - How to verify it Verified the internal BGP sessions are displayed correctly with show commands with this API is_bgp_session_internal()
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…c-net#5760) - Why I did it Update the routine is_bgp_session_internal() by checking the BGP_INTERNAL_NEIGHBOR table. Additionally to address the review comment sonic-net#5520 (comment) Add timer settings as will in the internal session templates and keep it minimal as these sessions which will always be up. Updates to the internal tests data + add all of it to template tests. - How I did it Updated the APIs and the template files. - How to verify it Verified the internal BGP sessions are displayed correctly with show commands with this API is_bgp_session_internal()
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…e. (sonic-net#5760)" (sonic-net#5871) This reverts commit c972052.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…-net#5874) Reintroduce sonic-net#5760, along with the fix needed in the template file for python3 compatibility.
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Jul 18, 2022
Reintroduce the msft templates for multi-asic(3164) after the following sonic public PR's ( for internal BGP neighbors) are available in internal-201911 branch. sonic-net#5520 sonic-net#5760 sonic-net/sonic-swss-common#389 sonic-net/sonic-utilities#1224 How did I verify ----------------- 1. Verified the external and internal BGP sessions are up, shown correctly in "show ip bgp summary -d all" and show ip interface commands. 2. Ran related 3164 tests to make sure it is passing. bgp/test_bgp_fact.py::test_bgp_facts[0-0] PASSED [ 16%] bgp/test_bgp_fact.py::test_bgp_facts[0-1] PASSED [ 33%] bgp/test_bgp_fact.py::test_bgp_facts[0-2] PASSED [ 50%] bgp/test_bgp_fact.py::test_bgp_facts[0-3] PASSED [ 66%] bgp/test_bgp_fact.py::test_bgp_facts[0-4] PASSED [ 83%] bgp/test_bgp_fact.py::test_bgp_facts[0-5] PASSED [100%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[0] PASSED [ 57%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[1] PASSED [ 63%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[2] SKIPPED [ 68%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[3] SKIPPED [ 73%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[4] SKIPPED [ 78%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[5] SKIPPED [ 84%]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Update the routine is_bgp_session_internal() by checking the BGP_INTERNAL_NEIGHBOR table.
Additionally to address the review comment #5520 (comment)
Add timer settings as will in the internal session templates and keep it minimal as these sessions which will always be up.
Updates to the internal tests data + add all of it to template tests.
- How I did it
Updated the APIs and the template files.
- How to verify it
Verified the internal BGP sessions are displayed correctly with show commands with this API is_bgp_session_internal()
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)