[platform mellanox] Substitute '-' symbol to '.' in Mellanox SDK vers… #5756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion to prevent problems with finding deb package Signed-off-by: Andriy Yurkiv <[email protected]>
|
retest this please |
stepanblyschak
approved these changes
Nov 3, 2020
|
retest this please |
|
retest vs please |
|
retest vsimage please |
lguohan
approved these changes
Nov 11, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…ion to prevent problems with finding deb package (sonic-net#5756) In case of non-GA SDK version there is '-' symbol in Mellanox SDK version name. (For example: 4.4.1306-006) In appropriate .deb packet there is '.' instead of '-'. Because of this there was problem while building SDK Signed-off-by: Andriy Yurkiv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion to prevent problems with finding deb package
Signed-off-by: Andriy Yurkiv [email protected]
- Why I did it
In case of non-GA SDK version there is '-' symbol in Mellanox SDK version name. (For example: 4.4.1306-006)
In appropriate .deb packet there is '.' instead of '-'. Because of this there was problem while building SDK
- How I did it
I have replaced '-' symbol with '.' for MLNX_SDK_DEB_VERSION
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)