Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bgpcfgd]: Convert bgpcfgd and bgpmon to python3 #5746

Merged
merged 4 commits into from
Nov 5, 2020

Conversation

pavel-shirshov
Copy link
Contributor

@pavel-shirshov pavel-shirshov commented Oct 29, 2020

Convert bgpmon to python3
Fix some issues in bgpmon

- Why I did it
Python2 is end of support

- How I did it

  1. Used 2to3 utility
  2. Manual editing to fix test failures
  3. Run on the dut and fix the issues in the sources

- How to verify it
Build an image and verify that bgpcfgd works

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Convert bgpmon to python3
Fix some issues in bgpmon
@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2020

This pull request introduces 1 alert when merging 04b04af into fd7e2a1 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request introduces 1 alert when merging b31e413 into b132ca0 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a class instantiation

@pavel-shirshov
Copy link
Contributor Author

retest broadcom please

@pavel-shirshov
Copy link
Contributor Author

retest vsimage please

@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2020

This pull request introduces 1 alert when merging 75ed8da into 10ab46f - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a class instantiation

@pavel-shirshov
Copy link
Contributor Author

retest mellanox please

@pavel-shirshov
Copy link
Contributor Author

retest vsimage please

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2020

This pull request introduces 1 alert when merging c55537e into e3164d5 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a class instantiation

@pavel-shirshov
Copy link
Contributor Author

retest vs please

@pavel-shirshov
Copy link
Contributor Author

retest vsimage please

@pavel-shirshov
Copy link
Contributor Author

retest vs please

@pavel-shirshov pavel-shirshov merged commit 13f8e9c into sonic-net:master Nov 5, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
* Convert bgpcfgd to python3

Convert bgpmon to python3
Fix some issues in bgpmon

* Add python3-swsscommon as depends

* Install dependencies

* reorder deps

Co-authored-by: Pavel Shirshov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants