Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minigraph.py]: Parse IP-in-IP tunnels from minigraph #5742

Merged
merged 7 commits into from
Nov 7, 2020
Merged

[minigraph.py]: Parse IP-in-IP tunnels from minigraph #5742

merged 7 commits into from
Nov 7, 2020

Conversation

theasianpianist
Copy link
Contributor

@theasianpianist theasianpianist commented Oct 29, 2020 •
edited
Loading

Signed-off-by: Lawrence Lee [email protected]

- Why I did it
IP-in-IP tunnel support
- How I did it
Take tunnel info from <TunnelInterface> tag in minigraph, and create tables in config_DB:

"TUNNEL": {
    "MUX_TUNNEL_0": {
        "tunnel_type": "IPINIP",
        "dst_ip": "26.1.1.10",
        "dscp_mode": "uniform",
        "encap_ecn_mode": "standard",
        "ecn_mode": "copy_from_outer",
        "ttl_mode": "pipe"
    }
}

- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@theasianpianist theasianpianist marked this pull request as ready for review October 29, 2020 01:34
@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2020

This pull request fixes 1 alert when merging be59dc0 into 6088bd5 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2020

This pull request fixes 1 alert when merging 3d25c49 into fd7e2a1 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2020

This pull request fixes 1 alert when merging 366abcb into fd7e2a1 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2020

This pull request fixes 1 alert when merging 64eb9d4 into e111204 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

prsunny
prsunny reviewed Oct 30, 2020
View reviewed changes
src/sonic-config-engine/minigraph.py Outdated Show resolved Hide resolved
src/sonic-config-engine/minigraph.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 1 alert when merging 7733c53 into e111204 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

prsunny
prsunny reviewed Oct 30, 2020
View reviewed changes
src/sonic-config-engine/minigraph.py Outdated Show resolved Hide resolved
src/sonic-config-engine/minigraph.py Outdated Show resolved Hide resolved
@lguohan
Copy link
Collaborator

lguohan commented Oct 30, 2020

retest mellanox please

@theasianpianist
[minigraph.py]: Address review comments
27fb241 
* Allow tunnel dst_ip from multiple loopback IPs
 (the first IPv4 loopback IP is used)
* Remove restrictions on tunnel types parsed
* Only add fields to tunnel table if the corresponding minigraph
attributes are present

Signed-off-by: Lawrence Lee <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request introduces 1 alert and fixes 1 when merging 27fb241 into 781188f - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

@theasianpianist
[minigraph.py]: Address review comments
5e8bc86 
* Check IP address version with ipaddress module
* Remove prefix length from tunnel dst_ip

Signed-off-by: Lawrence Lee <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2020

This pull request introduces 1 alert and fixes 1 when merging 5e8bc86 into 10ab46f - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

@theasianpianist
Copy link
Contributor Author

retest vsimage please

@theasianpianist
Copy link
Contributor Author

retest vsimage please

2 similar comments
@lguohan
Copy link
Collaborator

lguohan commented Nov 5, 2020

retest vsimage please

@theasianpianist
Copy link
Contributor Author

retest vsimage please

@theasianpianist
Copy link
Contributor Author

retest vsimage please

1 similar comment
@lguohan
Copy link
Collaborator

lguohan commented Nov 7, 2020

retest vsimage please

@lguohan lguohan merged commit 23b0e07 into sonic-net:master Nov 7, 2020
@theasianpianist theasianpianist deleted the mg-tunnel-parse branch November 9, 2020 20:19
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@theasianpianist @santhosh-kt
[minigraph.py]: Parse IP-in-IP tunnels from minigraph (sonic-net#5742)
c84ac87 
Take tunnel info from `<TunnelInterface>` tag in minigraph, and create tables in config_DB:

```
"TUNNEL": {
    "MUX_TUNNEL_0": {
        "tunnel_type": "IPINIP",
        "dst_ip": "26.1.1.10",
        "dscp_mode": "uniform",
        "encap_ecn_mode": "standard",
        "ecn_mode": "copy_from_outer",
        "ttl_mode": "pipe"
    }
}
```

Signed-off-by: Lawrence Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theasianpianist @lguohan @prsunny