Make backend device checking more robust #5730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
|
retest vsimage please |
2 similar comments
|
retest vsimage please |
|
retest vsimage please |
lguohan
reviewed
Nov 5, 2020
| @@ -30,7 +30,7 @@ dependent_startup=true | |||
| {# Router advertiser should only run on ToR (T0) devices which have #} | |||
| {# at least one VLAN interface which has an IPv6 address asigned #} | |||
| {%- set vlan_v6 = namespace(count=0) -%} | |||
| {%- if DEVICE_METADATA.localhost.type == "ToRRouter" -%} | |||
| {%- if "ToRRouter" in DEVICE_METADATA.localhost.type -%} | |||
There was a problem hiding this comment.
this seems to me some behaviorial change if the device is MgmtTorRouter. I am not saying this is not a good change, but maybe you want to confirm with @sumukhatv on M0 device.
lguohan
reviewed
Nov 5, 2020
| {%- set filename_postfix = 't0' %} | ||
| {%- elif switch_role.lower() == 'leafrouter' %} | ||
| {%- elif 'leafrouter' in switch_role.lower() %} |
There was a problem hiding this comment.
can you check if this will have impact on MgmtTorRouter. it should not have any buffer configuration, I mean should not have any impact. But I am not 100% sure.
Signed-off-by: Lawrence Lee <[email protected]>
prsunny
approved these changes
Nov 9, 2020
sumukhatv
approved these changes
Nov 9, 2020
lguohan
approved these changes
Nov 10, 2020
abdosi
pushed a commit
that referenced
this pull request
Nov 14, 2020
Treat devices that are ToRRouters (ToRRouters and BackEndToRRouters) the same when rendering templates Except for BackEndToRRouters belonging to a storage cluster, since these devices have extra sub-interfaces created Treat devices that are LeafRouters (LeafRouters and BackEndLeafRouters) the same when rendering templates Signed-off-by: Lawrence Lee <[email protected]>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
Treat devices that are ToRRouters (ToRRouters and BackEndToRRouters) the same when rendering templates Except for BackEndToRRouters belonging to a storage cluster, since these devices have extra sub-interfaces created Treat devices that are LeafRouters (LeafRouters and BackEndLeafRouters) the same when rendering templates Signed-off-by: Lawrence Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)