[process_checker] Fix 'NoSuchProcess' exception in process_checker #5716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
The
psutil
library used inprocess_checker
create a cache for each process when callingprocess_iter
. So, there is a small possibility that one process exists when calling process_iter, but not exists when calling cmdline, which will raise aNoSuchProcess
exception.This commit fix the issue.
Signed-off-by: bingwang [email protected]
- How I did it
Add a logic to catch
NoSuchProcess
and then ignore it.- How to verify it
Write a sample test script which looply creates a processe that runs only for a few milliseconds. Meanwhile,
process_checker
is running looply.Without this patch, the
NoSuchProcess
was found, and no exception was raises after the patch.- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Fix
NoSuchProcess
exception in process_checker- A picture of a cute animal (not mandatory but encouraged)