Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hostcfgd] Convert to Python 3; Add to sonic-host-services package #5713

Merged
merged 6 commits into from
Nov 7, 2020
Merged

[hostcfgd] Convert to Python 3; Add to sonic-host-services package #5713

merged 6 commits into from
Nov 7, 2020

Conversation

jleveque
Copy link
Contributor

- Why I did it

To consolidate host services and install via packages instead of file-by-file, also as part of migrating all of SONiC to Python 3, as Python 2 is no longer supported.

- How to verify it

Ensure hostcfgd is installed and runs

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

@jleveque jleveque requested a review from lguohan October 24, 2020 04:05
@jleveque jleveque self-assigned this Oct 24, 2020
@lgtm-com

This comment has been minimized.

Sign in to view
@lgtm-com
Copy link

lgtm-com bot commented Oct 24, 2020

This pull request fixes 1 alert when merging 1c5691225b0b7d7113687a1fb056b159845208c5 into 67408c8 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

lguohan
lguohan previously approved these changes Oct 25, 2020
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2020

This pull request fixes 1 alert when merging 658cba77006486426b7730cfd15a2fae230cf425 into 09d5a62 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@jleveque
Copy link
Contributor Author

Retest vsimage please

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2020

This pull request fixes 1 alert when merging d9446f252a8bc73e0ce6c97be17f4a47825006de into fd7e2a1 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@sonic-net sonic-net deleted a comment from daall Oct 29, 2020
@jleveque
Copy link
Contributor Author

jleveque commented Oct 29, 2020 •
edited
Loading

This PR is blocked due to a Python 3 bug in swsssdk. @qiluo-msft is working on a fix.

Update: Should be fixed by sonic-net/sonic-py-swsssdk#92. I have tested this change.

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2020

This pull request fixes 1 alert when merging f4083627f163863f1c2b9e4038c382e3941db218 into e111204 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@stepanblyschak stepanblyschak mentioned this pull request Oct 30, 2020
Merged
4 tasks
qiluo-msft
qiluo-msft previously approved these changes Oct 31, 2020
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Oct 31, 2020

This pull request fixes 1 alert when merging e3d2476ed015cd77086f7b64fd465b1c542780c4 into 781188f - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2020

This pull request fixes 1 alert when merging 2770264e142f4bba44c2bf6415ea396b218948d9 into 84d3a26 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

qiluo-msft
qiluo-msft previously approved these changes Nov 4, 2020
View reviewed changes
@lguohan
Copy link
Collaborator

lguohan commented Nov 5, 2020

retest vsimage please

lguohan
lguohan previously approved these changes Nov 5, 2020
View reviewed changes
@jleveque
Copy link
Contributor Author

jleveque commented Nov 5, 2020

Retest vsimage please

@jleveque jleveque dismissed stale reviews from lguohan and qiluo-msft via 6f5d066 November 6, 2020 00:32
@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2020

This pull request fixes 1 alert when merging 6f5d066505ef15aa85cd2ab99bc82fe376abcb52 into 13ff7b3 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2020

This pull request fixes 1 alert when merging 7635867 into 9bc693c - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@jleveque jleveque merged commit 04d0e8a into sonic-net:master Nov 7, 2020
@jleveque jleveque deleted the hostcfgd_py3 branch November 7, 2020 20:48
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@jleveque @santhosh-kt
[hostcfgd] Convert to Python 3; Add to sonic-host-services package (s…
0eaa324 
…onic-net#5713)

To consolidate host services and install via packages instead of file-by-file, also as part of migrating all of SONiC to Python 3, as Python 2 is no longer supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan lguohan left review comments

Assignees

@jleveque jleveque

Labels
Python 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jleveque @lguohan @qiluo-msft