[BFN] Rename variable in Montara platform debian/rules #5675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akokhan
approved these changes
Oct 20, 2020
jleveque
approved these changes
Oct 20, 2020
|
retest mellanox please |
1 similar comment
|
retest mellanox please |
|
retest broadcom please |
1 similar comment
|
retest broadcom please |
|
@jleveque , could you please merge this? Thank you |
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
Platforms .deb-package is not installed into the right directory, because variable PLATFORM was defined previously and variable in the makefile is ignored. https://www.gnu.org/software/make/manual/html_node/Overriding.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petro Bratash [email protected]
- Why I did it
Platforms .deb-package is not installed into the right directory, because variable
PLATFORMwas defined previously and variable in the makefile is ignored.https://www.gnu.org/software/make/manual/html_node/Overriding.html
- How I did it
Rename variable.
PLATFORM ----> PLATFORM_NAME- How to verify it
Сheck if the file exists (on Montara device):
/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/pcie.yaml- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)