Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DellEMC]: FanDrawer and get_high_critical_threshold Platform API implementation for S6000, S6100, Z9100 and Z9264F #5673

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

ArunSaravananBalachandran
Copy link
Contributor

- Why I did it

  • Implement FanDrawer and get_high_critical_threshold Platform API for S6000, S6100, Z9100 and Z9264F.
  • Fix incorrect fan direction values in S6100, Z9100

- How I did it

  • Added a new file fan_drawer.py for FanDrawer implementation.
  • Modified chassis.py to use FanDrawer for updating _fan_drawer_list and _fan_list.
  • Added ‘get_high_critical_threshold’ method in thermal.py for supported sensors in S6100, Z9100, Z9264.

- How to verify it

Wrote a python script to load chassis class and call the appropriate methods.
Logs: UT_logs.txt

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

[DellEMC]: FanDrawer and get_high_critical_threshold Platform API implementation for S6000, S6100, Z9100 and Z9264F

- A picture of a cute animal (not mandatory but encouraged)

…lementation for S6000, S6100, Z9100 and Z9264F
@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2020

This pull request introduces 4 alerts when merging be03bbe into d19d1dd - view on LGTM.com

new alerts:

  • 4 for Wrong number of arguments in a class instantiation

@ArunSaravananBalachandran
Copy link
Contributor Author

retest broadcom please

@jleveque jleveque merged commit 6145e4f into sonic-net:master Oct 30, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
…lementation for S6000, S6100, Z9100 and Z9264F (sonic-net#5673)

- Implement FanDrawer and get_high_critical_threshold Platform API for S6000, S6100, Z9100 and Z9264F.
- Fix incorrect fan direction values in S6100, Z9100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants