Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dell S6100] Properly release memory upon ICH driver deinit #5561

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

aravindmani-1
Copy link
Contributor

@aravindmani-1 aravindmani-1 commented Oct 8, 2020

- Why I did it

  • xcvrd daemon crashes in Dell S6100 with the following errors.
    Oct 6 00:52:43.603633 CYS04-0101-0321-12T1 ERR pmon#xcvrd: System failed to recover in 120 secs. Exiting...
    Oct 6 00:52:43.603633 CYS04-0101-0321-12T1 INFO pmon#xcvrd: State transition from 0 to 2
    Oct 6 00:52:44.912121 CYS04-0101-0321-12T1 ERR pmon#xcvrd: Error: dom info update thread received stop event,
    exiting...
    Oct 6 00:52:44.925275 CYS04-0101-0321-12T1 ERR pmon#xcvrd: Xcvrd main task stopped, exiting...

- How I did it

  • During platform deinitialization, dell_ich is not removed properly and when we do initialize s6100 platform, ICH driver sysfs attributes are not attached. Because of this, get_transceiver_change_event returns error and this leads xcvrd to crash.

- How to verify it

  • Do s6100 platform re-init and verify OIR works properly.
  • Check journalctl -a | grep dell_ich output.
    UT logs:
    S6100_mux_issue_UT.txt

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- A picture of a cute animal (not mandatory but encouraged)

@aravindmani-1
Copy link
Contributor Author

aravindmani-1 commented Oct 8, 2020

@jleveque Raised this PR to fix the xcvrd issue reported in S6100 platform.

@jleveque jleveque changed the title Dell S6100 ICH driver change [Dell S6100] Properly release memory upon ICH driver deinit Oct 8, 2020
@jleveque jleveque merged commit 6edb555 into sonic-net:master Oct 8, 2020
@aravindmani-1 aravindmani-1 deleted the Dell_ich_driver_changes branch October 9, 2020 05:58
yxieca pushed a commit that referenced this pull request Oct 14, 2020
During platform deinitialization, dell_ich is not removed properly and when we do initialize s6100 platform, ICH driver sysfs attributes are not attached. Because of this, get_transceiver_change_event returns error and this leads xcvrd to crash.
abdosi pushed a commit that referenced this pull request Oct 30, 2020
During platform deinitialization, dell_ich is not removed properly and when we do initialize s6100 platform, ICH driver sysfs attributes are not attached. Because of this, get_transceiver_change_event returns error and this leads xcvrd to crash.
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
…t#5561)

During platform deinitialization, dell_ich is not removed properly and when we do initialize s6100 platform, ICH driver sysfs attributes are not attached. Because of this, get_transceiver_change_event returns error and this leads xcvrd to crash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants