[bgpcfgd]: Extract classes into their own files. Run bgpcfgd as a module #5535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 2, 2020 14:39
…nic-net#5506)" This reverts commit 1f0f751.
3 tasks
lguohan
reviewed
Oct 2, 2020
| @@ -20,7 +20,7 @@ check program bgp|bgpd with path "/usr/bin/process_checker bgp /usr/lib/frr/bgpd | |||
| check program bgp|staticd with path "/usr/bin/process_checker bgp /usr/lib/frr/staticd" | |||
| if status != 0 for 5 times within 5 cycles then alert | |||
|
|
|||
| check program bgp|bgpcfgd with path "/usr/bin/process_checker bgp /usr/bin/python /usr/local/bin/bgpcfgd" | |||
| check program bgp|bgpcfgd with path "/usr/bin/process_checker bgp /usr/bin/python -m bgpcfgd" | |||
There was a problem hiding this comment.
you can use console_script
|
retest vs please |
lguohan
approved these changes
Oct 5, 2020
abdosi
pushed a commit
that referenced
this pull request
Oct 6, 2020
…ule (#5535) 1. Rename app module to bgpcfgd 2. Extract classes from one file to the module
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…ule (sonic-net#5535) 1. Rename app module to bgpcfgd 2. Extract classes from one file to the module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
- How I did it
Extract classes to its own files, grouping them.
So only import statement were changed in this PR. The code was preserved as it is.
- How to verify it
Build an image and run on your DUT
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)