-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker-orchagent]: Add NDP Proxy Daemon #5517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Oct 1, 2020
prsunny
reviewed
Oct 1, 2020
prsunny
previously approved these changes
Oct 1, 2020
theasianpianist
force-pushed
the
ndp-proxy
branch
from
October 1, 2020 18:33
2e1d671
to
20bb79d
Compare
retest baseimage please |
theasianpianist
force-pushed
the
ndp-proxy
branch
2 times, most recently
from
October 1, 2020 23:31
186dcc6
to
03be189
Compare
* Install `ndppd` during build * Configure `ndppd` based on Config DB at container start Signed-off-by: Lawrence Lee <[email protected]>
theasianpianist
force-pushed
the
ndp-proxy
branch
2 times, most recently
from
October 2, 2020 02:30
e287e7a
to
0866a95
Compare
lguohan
previously approved these changes
Oct 2, 2020
theasianpianist
force-pushed
the
ndp-proxy
branch
from
October 2, 2020 16:04
0866a95
to
07d5c71
Compare
Signed-off-by: Lawrence Lee <[email protected]>
theasianpianist
force-pushed
the
ndp-proxy
branch
from
October 2, 2020 16:15
07d5c71
to
9eb476c
Compare
there are still build failures |
@lguohan in the process of debugging |
Signed-off-by: Lawrence Lee <[email protected]>
theasianpianist
force-pushed
the
ndp-proxy
branch
from
October 2, 2020 16:41
b25ea23
to
6299775
Compare
Signed-off-by: Lawrence Lee <[email protected]>
@lguohan build failures fixed |
lguohan
approved these changes
Oct 3, 2020
theasianpianist
added a commit
that referenced
this pull request
Oct 5, 2020
This reverts commit 8c34409.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
* Install ndppd during image build, and copy config files to image * Configure proxy settings based on config DB at container start * Pipe ndppd output to logger inside container to log output in syslog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee [email protected]
Add NDP Proxy Daemon to the
docker-orchagent
image, and manage it withsupervisord
.- Why I did it
Native proxy NDP in Linux requires explicit neighbor entries in the kernel neighbor table, i.e. it's not possible to configure a subnet for proxy NDP. NDP Proxy Daemon (
ndppd
) bypasses the kernel neighbor table entirely and allows for subnets when configuring proxy NDP.- How I did it
ndppd
during image build, and copy config files to imagendppd
output tologger
inside container to log output in syslog- How to verify it
docker-orchagent
image to a device that supportsproxy_arp
.proxy_arp
for a VLAN interface in config_db.swss
container.config reload
ip -6 neigh
. The IPv6 address pinged in step 7 should beREACHABLE
.- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Add support for proxy NDP
- A picture of a cute animal (not mandatory but encouraged)