Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Fix truncated manufacture date returned from platform API #5473

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Sep 28, 2020

- Why I did it

The manufacture date returned from platform API was truncated, time is not included.

05/11/2017 17:20:17 ------> 05/11/2017

- How I did it

Revise the regular expression used for matching.

- How to verify it

Call the platform API and check whether the manufacture date is correctly returned.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@keboliu
Copy link
Collaborator Author

keboliu commented Sep 28, 2020

retest this please

@Junchao-Mellanox
Copy link
Collaborator

retest mellanox please

1 similar comment
@Junchao-Mellanox
Copy link
Collaborator

retest mellanox please

@Junchao-Mellanox
Copy link
Collaborator

retest vsimage please

@Junchao-Mellanox
Copy link
Collaborator

retest broadcom please

@jleveque jleveque merged commit 4062368 into sonic-net:master Oct 3, 2020
abdosi pushed a commit that referenced this pull request Oct 6, 2020
…5473)

The manufacture date returned from platform API was truncated, time is not included. Revise the regular expression used for matching.
@keboliu keboliu deleted the eeprom-fix-re branch January 2, 2021 01:26
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
…onic-net#5473)

The manufacture date returned from platform API was truncated, time is not included. Revise the regular expression used for matching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants