[sonic-platform-common] Install Python 3 package in host OS and PMon container #5461
Conversation
Signed-off-by: Volodymyr Boyko <[email protected]>
Signed-off-by: Volodymyr Boyko <[email protected]>
|
@vboykox: Thanks for opening this PR! Is it ready for merge? I saw "WIP" in the title, so I wanted to wait for an update from you. |
vboykox
changed the title
|
@jleveque yes, the PR is ready for merge |
|
Retest broadcom please |
|
Retest vsimage please |
|
@vboykox: The Python 3 sonic-platform-common package will also need to be installed in the PMon container. Do you intend to do this in a separate PR? |
jleveque
changed the title
Thanks for pointing that out |
… py3 packages Use PEP-425 Python tag to differentiate between package python version Signed-off-by: Volodymyr Boyko <[email protected]>
|
retest baseimage please |
|
@vboykox: The Docker container install of the Python 3 wheel is failing. The issue is it's trying to install a Python 3 wheel using Python 2 pip. This is because the Dockerfile is using a macro from dockers/dockerfile-macros.j2, but the macro needs to be updated to be smarter. In the meantime, I suggest you update this section to work like the change I made here. I can work on updating the macro in the future. |
vboykox
changed the title
vboykox
force-pushed
the
add_sonic_platform_common_py3_to_fs
branch
from
b473da8 to
3106a78
Compare
…kages Signed-off-by: Volodymyr Boyko <[email protected]>
… startup Signed-off-by: Volodymyr Boyko <[email protected]>
vboykox
force-pushed
the
add_sonic_platform_common_py3_to_fs
branch
from
031ebd2 to
2427b81
Compare
|
retest mellanox please |
|
retest broadcom please |
vboykox
changed the title
…container (sonic-net#5461) Signed-off-by: Volodymyr Boyko <[email protected]>
Signed-off-by: Volodymyr Boyko [email protected]
- Why I did it
To include python 3 sonic-platform-common into SONiC image
- How to verify it
ls /usr/local/lib/python3.7/- Which release branch to backport (provide reason below if selected)