-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[device]: Add support for Mellanox MSN2100 #544
Conversation
MSN2100 runs on Spectrum silicon and has 16 100GbE ports. Signed-off-by: marian-pritsak <[email protected]>
@@ -21,6 +21,8 @@ ExecStartPre=/usr/bin/docker exec database redis-cli -n 2 FLUSHDB | |||
ExecStartPre=/etc/init.d/sxdkernel start | |||
ExecStartPre=/usr/bin/mst start | |||
ExecStartPre=/sbin/modprobe i2c-dev | |||
# i2c_ismt driver resides on the same bus as lpc_i2c, we remove it since its not used in Mellanox box to allow lpc_i2c to be inserted | |||
ExecStartPre=-/sbin/rmmod i2c_ismt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this belong to swss? shouldn't this be included in your hw_management package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is specific only to SONiC kernel, which inserts i2c_ismt module
Distro kernels do not have this module inserted by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you help to find out who inserted this module on your platform? I do not think we explicitly inserted this module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SN2100 has Intel Atom chip with SMBus controller, which causes i2c-ismt driver to be inserted during device initialization.
Since we include driver in our config it is loaded by default.
Is it ok if I'll remove it from config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, other platform uses the driver, I believe. I still feel the right place should the hw_management package, in its init script, it can first check whether the module is loaded or not, then remove if it is loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem.
It can be done in hw-management start script
@jleveque , to review |
update multiDB changes in sairedis, including: [MultiDB]: repalce old APIs with New APIs incuding testing (#537) [syncd] Move port map and port map parser to proper class (#542) [syncd] Update syncd to expect correct object query message (#548) Support for snat available entry switch attribute in vslib (needed to run vs pytests) (#546) Move apiInitialized flag to Globals namespace (#545) Move command line options and parser to separate classes (#541) Move ntf_queue to proper NotificationQueue class (#539) Move api mutex to global class and add sairedis namespace (#544) Clean sairedis.h header (#543) Fix mlnx.pl script for perl include local directory (#540) Layer 2 Forwarding Enhancements (#510) Signed-off-by: Dong Zhang [email protected]
…net#544) Enable configuring IPv4 and IPv6 addresses on regular ports Add tests to test IPv4 add/remove to regular ports Signed-off-by: Shu0T1an ChenG <[email protected]>
[schema] Add EXP to TC map config table (sonic-net#537) [CI]: Swap the python code coverage report with the cpp report (sonic-net#544) Remove SWIG generated files from coverage report (sonic-net#542) Update database defintions for PINs / P4Runtime (sonic-net#536) [ci]: Support code coverage (sonic-net#539) Fix the option missing in kernel config issue (sonic-net#541) Add SRV6 APP tables (sonic-net#538) [schema] Rename CBF config tables (sonic-net#535)
[schema] Add EXP to TC map config table (#537) [CI]: Swap the python code coverage report with the cpp report (#544) Remove SWIG generated files from coverage report (#542) Update database defintions for PINs / P4Runtime (#536) [ci]: Support code coverage (#539) Fix the option missing in kernel config issue (#541) Add SRV6 APP tables (#538) [schema] Rename CBF config tables (#535)
MSN2100 runs on Spectrum silicon and has 16 100GbE ports.
Signed-off-by: marian-pritsak [email protected]