Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DellEMC Z9264f buffer changes #5429

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

aravindmani-1
Copy link
Contributor

@aravindmani-1 aravindmani-1 commented Sep 22, 2020

- Why I did it
Converted two SP model to single pool model and modified the buffer size.
- How I did it
Changed buffer_default settings for all the DellEMC Z9264f HWSKU's.
- How to verify it
Check SP register values in NPU shell.
- Which release branch to backport (provide reason below if selected)
Need to be cherry picked for 201911 branch.

  • 201811
  • 201911
  • 202006

@aravindmani-1 aravindmani-1 changed the title Dell emc z9264f buffer changes DellEMC z9264f buffer changes Sep 22, 2020
@aravindmani-1 aravindmani-1 changed the title DellEMC z9264f buffer changes DellEMC Z9264f buffer changes Sep 22, 2020
@lguohan lguohan requested a review from neethajohn September 29, 2020 22:27
@aravindmani-1
Copy link
Contributor Author

Team,

Can you please review this PR?.

@neethajohn
Copy link
Contributor

What is the motivation to moving to single pool on the egress? Other platforms using Th2 follow the 2 pool model on egress

@aravindmani-1
Copy link
Contributor Author

Hi @neethajohn ,

In our newer platforms, we started to use single pool model.
To maintain uniformity across newer Dell platforms, we're changing it to single SP model.
Existing Ingress and egress buffer values are also modified in this PR.

@aravindmani-1
Copy link
Contributor Author

Team,

Can you please merge this PR?.

@lguohan lguohan merged commit 42d2bf1 into sonic-net:master Oct 29, 2020
@aravindmani-1 aravindmani-1 deleted the DellEMC_Z9264f_buffer_changes branch October 29, 2020 15:08
@aravindmani-1
Copy link
Contributor Author

@jleveque We need this PR to be merged in 201911 branch. I've already added cherry pick request.
Can you please help to merge this PR?.

@jleveque
Copy link
Contributor

@abdosi for awareness re: cherry-pick to 201911.

abdosi pushed a commit that referenced this pull request Nov 14, 2020
**- Why I did it**
Converted two SP model to single pool model and modified the buffer size.
**- How I did it**
Changed buffer_default settings for all the DellEMC Z9264f HWSKU's.
**- How to verify it**
Check SP register values in NPU shell.
**- Which release branch to backport (provide reason below if selected)**
Need to be cherry picked for 201911 branch.
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
**- Why I did it**
Converted two SP model to single pool model and modified the buffer size.
**- How I did it**
Changed buffer_default settings for all the DellEMC Z9264f HWSKU's.
**- How to verify it**
Check SP register values in NPU shell.
**- Which release branch to backport (provide reason below if selected)**
Need to be cherry picked for 201911 branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants