Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ebtables] Replace binary config file with text config file #5252

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

antony-rheneus
Copy link
Contributor

Issue: Binary ebtables config file is CPU arch dependent
Fix: Load the text config during firsttime boot and
Generate the binary persistent atomic file

Signed-off-by: Antony Rheneus [email protected]

- Why I did it

- How I did it

- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Issue: Binary ebtables config file is CPU arch dependent
Fix: Load the text config during firsttime boot and
     Generate the binary persistent atomic file

Signed-off-by: Antony Rheneus <[email protected]>
@lguohan lguohan requested a review from prsunny August 26, 2020 07:10
Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm..

@prsunny prsunny requested a review from yxieca August 26, 2020 15:47
@jleveque jleveque changed the title [ebtbles] Replace binary config file to text config file for ebtables [ebtbles] Replace binary config file with text config file Aug 26, 2020
@jleveque jleveque changed the title [ebtbles] Replace binary config file with text config file [ebtables] Replace binary config file with text config file Aug 27, 2020
@jleveque
Copy link
Contributor

Retest vsimage please

@prsunny
Copy link
Contributor

prsunny commented Aug 28, 2020

retest vsimage please

Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yxieca , can you review?

Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ebtables service is only "After=local-fs.target", but not after rc.local. Will there be race condition?

@antony-rheneus
Copy link
Contributor Author

ebtables service is only "After=local-fs.target", but not after rc.local. Will there be race condition?

No, as it is converting configuration file to atomic config, and at that time manually rules cannot be added to ebtables

antony-rheneus added a commit to antony-rheneus/sonic-scripts that referenced this pull request Sep 3, 2020
@prsunny prsunny merged commit f136fd0 into sonic-net:master Sep 4, 2020
abdosi pushed a commit that referenced this pull request Jan 28, 2021
…#5252)

Issue: Binary ebtables config file is CPU arch dependent
Fix: Load the text config during firsttime boot and
     Generate the binary persistent atomic file

Signed-off-by: Antony Rheneus <[email protected]>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
…sonic-net#5252)

Issue: Binary ebtables config file is CPU arch dependent
Fix: Load the text config during firsttime boot and
     Generate the binary persistent atomic file

Signed-off-by: Antony Rheneus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants