Changes to add template support for copp.json. #5053
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| [ | ||
| { | ||
| "COPP_TABLE:default": { | ||
| "queue": "0", | ||
| "meter_type":"packets", | ||
| "mode":"sr_tcm", | ||
| "cir":"600", | ||
| "cbs":"600", | ||
| "red_action":"drop" | ||
| }, | ||
| "OP": "SET" | ||
| }, | ||
| { | ||
| "COPP_TABLE:trap.group.bgp.lacp": { | ||
| "trap_ids": "bgp,bgpv6,lacp", | ||
| "trap_action":"trap", | ||
| "trap_priority":"4", | ||
| "queue": "4" | ||
| }, | ||
| "OP": "SET" | ||
| }, | ||
| { | ||
| "COPP_TABLE:trap.group.arp": { | ||
| "trap_ids": "arp_req,arp_resp,neigh_discovery", | ||
| "trap_action":"copy", | ||
| "trap_priority":"4", | ||
| "queue": "4", | ||
| "meter_type":"packets", | ||
| "mode":"sr_tcm", | ||
| "cir":"600", | ||
| "cbs":"600", | ||
| "red_action":"drop" | ||
| }, | ||
| "OP": "SET" | ||
| }, | ||
| {% if DEVICE_METADATA['localhost']['type'] == "ToRRouter" %} | ||
| { | ||
| "COPP_TABLE:trap.group.lldp.dhcp.dhcpv6.udld": { | ||
| "trap_ids": "lldp,dhcp,dhcpv6,udld", | ||
| "trap_action":"trap", | ||
| "trap_priority":"4", | ||
| "queue": "4" | ||
| }, | ||
| "OP": "SET" | ||
| }, | ||
| {% else %} | ||
| { | ||
| "COPP_TABLE:trap.group.lldp.udld": { | ||
| "trap_ids": "lldp,udld", | ||
| "trap_action":"trap", | ||
|
There was a problem hiding this comment. If type (if defined) is not ToRRouter have the trap-ids only for lldp & udlp and else case have ""trap_ids": "lldp,dhcp,dhcpv6,udld"," There was a problem hiding this comment. @venkatmahalingam yes this is the behavior There was a problem hiding this comment. @venkatmahalingam got your point. Updated accordingly. |
||
| "trap_priority":"4", | ||
| "queue": "4" | ||
| }, | ||
| "OP": "SET" | ||
| }, | ||
| {% endif %} | ||
| { | ||
| "COPP_TABLE:trap.group.ip2me": { | ||
| "trap_ids": "ip2me", | ||
| "trap_action":"trap", | ||
| "trap_priority":"1", | ||
| "queue": "1", | ||
| "meter_type":"packets", | ||
| "mode":"sr_tcm", | ||
| "cir":"6000", | ||
| "cbs":"6000", | ||
| "red_action":"drop" | ||
| }, | ||
| "OP": "SET" | ||
| }, | ||
| { | ||
| "COPP_TABLE:trap.group.nat": { | ||
| "trap_ids": "src_nat_miss,dest_nat_miss", | ||
| "trap_action":"trap", | ||
| "trap_priority":"1", | ||
| "queue": "1", | ||
| "meter_type":"packets", | ||
| "mode":"sr_tcm", | ||
| "cir":"600", | ||
| "cbs":"600", | ||
| "red_action":"drop" | ||
| }, | ||
| "OP": "SET" | ||
| } | ||
| ] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to check for the existence of
type. If not present, the template might crash - RefThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please ensure if the type is not defined, the trap is installed? Type is not a mandatory parameter and this might cause backward compatibility issues in cases where type field is not defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prsunny @dgsudharsan Updated to add default else condition for backward compatibility
if DEVICE_METADATA and it sub-parameters are not define.