-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yang_models]: yang models for device_metadata, device_neighbor, flex… #4442
Conversation
@renukamanavalan , @zhenggen-xu , @li-pingmao , @vasant17 , @samaity |
retest vsimage please |
2dad754
to
3f6eaf9
Compare
Gentle Reminder: Kinldy review when possible. @renukamanavalan , @zhenggen-xu , @li-pingmao , @vasant17 , @samaity |
3f6eaf9
to
9432f1b
Compare
These Yang models are part of our Dynamic Port Breakout branch, I think it is best to merge them in master. + back-port to 202006. Thanks for review. |
retest vsimage please |
retest broadcom please |
retest mellanox please |
@lguohan @renukamanavalan : I resolved all comments, Kindly review and merge, Thanks a lot for help. |
Could you please tell me when this PR is planned to be merged? |
@renukamanavalan @lguohan |
@lguohan: it will help if we can merge this as well, it is risk free PR :). |
79d7602
to
9ad09d2
Compare
Rebased |
@renukamanavalan : Rebased this, which inturn asked for the forced push. This has removed your approval " praveen-li dismissed renukamanavalan’s stale review via 9ad09d2 2 minutes ago". Kindly approve again. Thanks a lot. |
…_counters, crm, versions. Changes: 1.) yang models for device_metadata, device_neighbor, flex_counters, crm, versions. Signed-off-by: Praveen Chaudhary [email protected]:
…neighbor, flex_counters, crm, versions. Changes: . Test cases for above yang models. Signed-off-by: Praveen Chaudhary [email protected]
Signed-off-by: Praveen Chaudhary [email protected]
…Correction. Signed-off-by: Praveen Chaudhary [email protected]
Changes -- CRM yang models nexthop_group, nexthop_group_member fields. -- Test for new fileds. -- sonic-crm.yang: Fix PERCENTAGE -> percentage. Signed-off-by: Praveen Chaudhary [email protected] src/sonic-yang-models/tests/yang_model_tests/yangTest.json
With merge of new Yang models, there should be no extra\unprocessed table in Test Config. Signed-off-by: Praveen Chaudhary <[email protected]>
Signed-off-by: Praveen Chaudhary <[email protected]>
Signed-off-by: Praveen Chaudhary<[email protected]>
Signed-off-by: Praveen Chaudhary<[email protected]> RB= G=lnos-reviewers R=pchaudhary,pmao,rmolina,samaity,sfardeen,zxu A=
-- flex counter. -- versions. -- tests. Signed-off-by: Praveen Chaudhary<[email protected]>
-- Fix flex coounter tests. -- Add PORT_RATES in flex yang. -- Change SAMPLE CONFIG as per new constraints. Signed-off-by: Praveen Chaudhary<[email protected]>
…-crm.yang Signed-off-by: Praveen Chaudhary<[email protected]>
Signed-off-by: Praveen Chaudhary<[email protected]>
fc032e6
to
7cc5a4d
Compare
retest vsimage please |
sonic-net#4442) Changes: 1.) yang models for device_metadata, device_neighbor, flex_counters, crm, versions. 2.) Test cases for above yang models. Signed-off-by: Praveen Chaudhary [email protected]:
…_counters, crm, versions.
Changes:
1.) yang models for device_metadata, device_neighbor, flex_counters, crm, versions.
2.) Test cases for above yang models.
Signed-off-by: Praveen Chaudhary [email protected]
- What I did
Changes:
1.) yang models for device_metadata, device_neighbor, flex_counters, crm, versions.
2.) Test cases for above yang models.
- How I did it
Wrote yang models for device_metadata, device_neighbor, flex_counters, crm, versions based on
https://github.com/Azure/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md and
https://github.com/Azure/SONiC/wiki/Configuration
- How to verify it
New Yang Models Testing: