[Mellanox] sfplpmset scripts rule out CPU ports to avoid any operation on them #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenxs
approved these changes
Feb 27, 2020
nazariig
approved these changes
Feb 27, 2020
|
retest this please |
liat-grozovik
approved these changes
Mar 1, 2020
|
retest vsimage please |
rlhui
pushed a commit
that referenced
this pull request
Mar 4, 2020
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add logic to rule out all CPU ports to avoid any operation on them, SDK API called in the lpmode set scripts not applicable to them and will cause SDK error log.
- How I did it
Judge the port type to see if it is CPU port, if CPU port then skip it.
- How to verify it
run "sfputil lpmode on/off EthernetX" command to test
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)