[devices]: DellEMC new platform support for DellEMC s5296f- 96x25G #3960

srideepDell · 2020-01-02T08:50:27Z

* Switch Vendor: DellEMC
* Switch SKU: s5296F
* ASIC Vendor: Broadcom
* Swich ASIC: Trident3
* Port Configuration: 96x25G
* SONiC Image: sonic-broadcom.bin

* NPU device profile support Added 25G(96x25G,8x100G) and 10G(96x10G,8x100G) configruation ( 25G is default).
* LED support for s5296f,
* platform changes include syseeprom,ipmitool implementation for platform_sensors script is inclued in pmon startup.

- What I did
Added platform support for DellEMC S5296f
- How I did it
Added files,driver,npu configs for the platforms
- How to verify it
Verified build and tested on DellEMC S5296 platform.
logs attached below.
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

* Switch Vendor: DellEMC * Switch SKU: s5296F * ASIC Vendor: Broadcom * Swich ASIC: Trident3 * Port Configuration: 96x25G * SONiC Image: sonic-broadcom.bin * NPU device profile support Added 25G(96x25G,8x100G) and 10G(96x10G,8x100G) configruation ( 25G is default). * LED support for s5296f, * platform changes include syseeprom,ipmitool implementation for platform_sensors script is inclued in pmon startup.

srideepDell · 2020-01-02T08:52:27Z

Test logs

root@sonic:~# show platform summary
Platform: x86_64-dellemc_s5296f_c3538-r0
HwSKU: DellEMC-S5296f-P-25G
ASIC: broadcom

root@sonic:~# show platform syseeprom
TlvInfo Header:
Id String: TlvInfo
Version: 1
Total Length: 174
TLV Name Code Len Value

Product Name 0x21 9 S5296F-ON
Part Number 0x22 6 099K11
Serial Number 0x23 20 CN099K11CES008C80002
Base MAC Address 0x24 6 3C:2C:30:29:78:80
Manufacture Date 0x25 19 12/14/2018 16:29:10
Device Version 0x26 1 1
Label Revision 0x27 3 A00
Platform Name 0x28 30 X86_64-dellemc_s5296f_c3538-r0
ONIE Version 0x29 10 3.40.1.1-6
MAC Addresses 0x2A 2 384
Manufacturer 0x2B 5 CES00
Manufacture Country 0x2C 2 CN
Vendor Name 0x2D 4 Dell
Diag Version 0x2E 11 3.00.3.41-2
Service Tag 0x2F 7 7XJ00Q2
Vendor Extension 0xFD 1
CRC-32 0xFE 4 0x898EFAB5

(checksum valid)

root@sonic:~# show environment
acpitz-virtual-0
Adapter: Virtual device
temp1: +0.0 C (crit = +94.0 C)

coretemp-isa-0000
Adapter: ISA adapter
Physical id 0: +47.0 C (high = +74.0 C, crit = +94.0 C)
Core 2: +45.0 C (high = +74.0 C, crit = +94.0 C)
Core 6: +45.0 C (high = +74.0 C, crit = +94.0 C)
Core 8: +44.0 C (high = +74.0 C, crit = +94.0 C)
Core 12: +44.0 C (high = +74.0 C, crit = +94.0 C)

Onboard Temperature Sensors:
PT_Left_temp: 29 degrees C
PT_Mid_temp: 33 degrees C
PT_Right_temp: 28 degrees C
Broadcom Temp: 39 degrees C
Inlet Airflow Temp: 33 degrees C
CPU Temp: 47 degrees C

Fan Trays:
Fan Tray 1:
Fan Speed: 5040 RPM
Fan State: Normal
Fan Tray 2:
Fan Speed: 5040 RPM
Fan State: Normal
Fan Tray 3:
Fan Speed: 5160 RPM
Fan State: Normal
Fan Tray 4:
Fan Speed: 5160 RPM
Fan State: Normal

PSUs:
PSU1:
FAN Normal Temperature: 56 degrees C
FAN AirFlow Temperature: 34 degrees C
FAN RPM: 9000 RPM
Input Voltage: 117.70 Volts
Output Voltage: 12.40 Volts
Input Power: 160 Watts
Output Power: 140 Watts
Input Current: 1.28 Amps
Output Current: 11.50 Amps

PSU 2 Not present

Total Power:                       160 Watts

root@sonic:~#

root@sonic:~# show interfaces status
Interface Lanes Speed MTU Alias Vlan Oper Admin Type Asym PFC

Ethernet0 Ethernet1 Ethernet2 Ethernet3 Ethernet4 Ethernet5 Ethernet6 Ethernet7 Ethernet8 Ethernet9 Ethernet10 Ethernet11 Ethernet12 Ethernet13 Ethernet14 Ethernet15 Ethernet16 Ethernet17 Ethernet18 Ethernet19 Ethernet20 Ethernet21 Ethernet22 Ethernet23 Ethernet24 Ethernet25 Ethernet26 Ethernet27 Ethernet28 Ethernet29 Ethernet30 Ethernet31 Ethernet32 Ethernet33 Ethernet34 Ethernet35 Ethernet36 Ethernet37 Ethernet38 Ethernet39 Ethernet40 Ethernet41 Ethernet42 Ethernet43 Ethernet44 Ethernet45 Ethernet46 Ethernet47 Ethernet48 Ethernet49 Ethernet50 Ethernet51 Ethernet52 Ethernet53 Ethernet54 Ethernet55 Ethernet56 Ethernet57 Ethernet58 Ethernet59 Ethernet60 Ethernet61 Ethernet62 Ethernet63 Ethernet64 Ethernet65 Ethernet66 Ethernet67 Ethernet68 Ethernet69 Ethernet70 Ethernet71 Ethernet72 Ethernet73 Ethernet74 Ethernet75 Ethernet76 Ethernet77 Ethernet78 Ethernet79 Ethernet80 Ethernet81 Ethernet82 Ethernet83 Ethernet84 Ethernet85 Ethernet86 Ethernet87 Ethernet88 Ethernet89 Ethernet90 Ethernet91 Ethernet92 Ethernet93 Ethernet94 Ethernet95 Ethernet96 29,30,31,32 Ethernet97 21,22,23,24 Ethernet98 125,126,127,128 Ethernet99 85,86,87,88 Ethernet100 57,58,59,60 Ethernet101 61,62,63,64 Ethernet102 121,122,123,124 Ethernet103 93,94,95,96 root@sonic:~# 5 25G 9100 twentyfiveGigE1/1/1 routed down up SFP/SFP+/SFP28 N/A
6 25G 9100 twentyfiveGigE1/1/2 routed up up SFP/SFP+/SFP28 N/A
7 25G 9100 twentyfiveGigE1/1/3 routed up up SFP/SFP+/SFP28 N/A
8 25G 9100 twentyfiveGigE1/1/4 routed up up SFP/SFP+/SFP28 N/A
13 25G 9100 twentyfiveGigE1/2/1 routed up up SFP/SFP+/SFP28 N/A
14 25G 9100 twentyfiveGigE1/2/2 routed up up SFP/SFP+/SFP28 N/A
15 25G 9100 twentyfiveGigE1/2/3 routed up up SFP/SFP+/SFP28 N/A
16 25G 9100 twentyfiveGigE1/2/4 routed up up SFP/SFP+/SFP28 N/A
17 25G 9100 twentyfiveGigE1/3/1 routed up up SFP/SFP+/SFP28 N/A
18 25G 9100 twentyfiveGigE1/3/2 routed up up SFP/SFP+/SFP28 N/A
19 25G 9100 twentyfiveGigE1/3/3 routed up up SFP/SFP+/SFP28 N/A
20 25G 9100 twentyfiveGigE1/3/4 routed up up SFP/SFP+/SFP28 N/A
37 25G 9100 twentyfiveGigE1/4/1 routed up up SFP/SFP+/SFP28 N/A
38 25G 9100 twentyfiveGigE1/4/2 routed up up SFP/SFP+/SFP28 N/A
39 25G 9100 twentyfiveGigE1/4/3 routed up up SFP/SFP+/SFP28 N/A
40 25G 9100 twentyfiveGigE1/4/4 routed up up SFP/SFP+/SFP28 N/A
45 25G 9100 twentyfiveGigE1/5/1 routed up up SFP/SFP+/SFP28 N/A
46 25G 9100 twentyfiveGigE1/5/2 routed up up SFP/SFP+/SFP28 N/A
47 25G 9100 twentyfiveGigE1/5/3 routed up up SFP/SFP+/SFP28 N/A
48 25G 9100 twentyfiveGigE1/5/4 routed up up SFP/SFP+/SFP28 N/A
53 25G 9100 twentyfiveGigE1/6/1 routed up up SFP/SFP+/SFP28 N/A
54 25G 9100 twentyfiveGigE1/6/2 routed up up SFP/SFP+/SFP28 N/A
55 25G 9100 twentyfiveGigE1/6/3 routed up up SFP/SFP+/SFP28 N/A
56 25G 9100 twentyfiveGigE1/6/4 routed up up SFP/SFP+/SFP28 N/A
65 25G 9100 twentyfiveGigE1/7/1 routed up up SFP/SFP+/SFP28 N/A
66 25G 9100 twentyfiveGigE1/7/2 routed up up SFP/SFP+/SFP28 N/A
67 25G 9100 twentyfiveGigE1/7/3 routed up up SFP/SFP+/SFP28 N/A
68 25G 9100 twentyfiveGigE1/7/4 routed up up SFP/SFP+/SFP28 N/A
73 25G 9100 twentyfiveGigE1/8/1 routed up up SFP/SFP+/SFP28 N/A
74 25G 9100 twentyfiveGigE1/8/2 routed up up SFP/SFP+/SFP28 N/A
75 25G 9100 twentyfiveGigE1/8/3 routed up up SFP/SFP+/SFP28 N/A
76 25G 9100 twentyfiveGigE1/8/4 routed up up SFP/SFP+/SFP28 N/A
89 25G 9100 twentyfiveGigE1/9/1 routed up up SFP/SFP+/SFP28 N/A
90 25G 9100 twentyfiveGigE1/9/2 routed up up SFP/SFP+/SFP28 N/A
91 25G 9100 twentyfiveGigE1/9/3 routed up up SFP/SFP+/SFP28 N/A
92 25G 9100 twentyfiveGigE1/9/4 routed up up SFP/SFP+/SFP28 N/A
101 25G 9100 twentyfiveGigE1/10/1 routed up up SFP/SFP+/SFP28 N/A
102 25G 9100 twentyfiveGigE1/10/2 routed up up SFP/SFP+/SFP28 N/A
103 25G 9100 twentyfiveGigE1/10/3 routed up up SFP/SFP+/SFP28 N/A
104 25G 9100 twentyfiveGigE1/10/4 routed up up SFP/SFP+/SFP28 N/A
109 25G 9100 twentyfiveGigE1/11/1 routed up up SFP/SFP+/SFP28 N/A
110 25G 9100 twentyfiveGigE1/11/2 routed up up SFP/SFP+/SFP28 N/A
111 25G 9100 twentyfiveGigE1/11/3 routed up up SFP/SFP+/SFP28 N/A
112 25G 9100 twentyfiveGigE1/11/4 routed up up SFP/SFP+/SFP28 N/A
117 25G 9100 twentyfiveGigE1/12/1 routed up up SFP/SFP+/SFP28 N/A
118 25G 9100 twentyfiveGigE1/12/2 routed up up SFP/SFP+/SFP28 N/A
119 25G 9100 twentyfiveGigE1/12/3 routed up up SFP/SFP+/SFP28 N/A
120 25G 9100 twentyfiveGigE1/12/4 routed up up SFP/SFP+/SFP28 N/A
1 25G 9100 twentyfiveGigE1/13/1 routed up up SFP/SFP+/SFP28 N/A
2 25G 9100 twentyfiveGigE1/13/2 routed up up SFP/SFP+/SFP28 N/A
3 25G 9100 twentyfiveGigE1/13/3 routed up up SFP/SFP+/SFP28 N/A
4 25G 9100 twentyfiveGigE1/13/4 routed up up SFP/SFP+/SFP28 N/A
9 25G 9100 twentyfiveGigE1/14/1 routed up up SFP/SFP+/SFP28 N/A
10 25G 9100 twentyfiveGigE1/14/2 routed up up SFP/SFP+/SFP28 N/A
11 25G 9100 twentyfiveGigE1/14/3 routed up up SFP/SFP+/SFP28 N/A
12 25G 9100 twentyfiveGigE1/14/4 routed up up SFP/SFP+/SFP28 N/A
25 25G 9100 twentyfiveGigE1/15/1 routed up up SFP/SFP+/SFP28 N/A
26 25G 9100 twentyfiveGigE1/15/2 routed up up SFP/SFP+/SFP28 N/A
27 25G 9100 twentyfiveGigE1/15/3 routed up up SFP/SFP+/SFP28 N/A
28 25G 9100 twentyfiveGigE1/15/4 routed up up SFP/SFP+/SFP28 N/A
33 25G 9100 twentyfiveGigE1/16/1 routed up up SFP/SFP+/SFP28 N/A
34 25G 9100 twentyfiveGigE1/16/2 routed up up SFP/SFP+/SFP28 N/A
35 25G 9100 twentyfiveGigE1/16/3 routed up up SFP/SFP+/SFP28 N/A
36 25G 9100 twentyfiveGigE1/16/4 routed up up SFP/SFP+/SFP28 N/A
41 25G 9100 twentyfiveGigE1/17/1 routed up up SFP/SFP+/SFP28 N/A
42 25G 9100 twentyfiveGigE1/17/2 routed up up SFP/SFP+/SFP28 N/A
43 25G 9100 twentyfiveGigE1/17/3 routed up up SFP/SFP+/SFP28 N/A
44 25G 9100 twentyfiveGigE1/17/4 routed up up SFP/SFP+/SFP28 N/A
49 25G 9100 twentyfiveGigE1/18/1 routed up up SFP/SFP+/SFP28 N/A
50 25G 9100 twentyfiveGigE1/18/2 routed up up SFP/SFP+/SFP28 N/A
51 25G 9100 twentyfiveGigE1/18/3 routed up up SFP/SFP+/SFP28 N/A
52 25G 9100 twentyfiveGigE1/18/4 routed up up SFP/SFP+/SFP28 N/A
69 25G 9100 twentyfiveGigE1/19/1 routed up up SFP/SFP+/SFP28 N/A
70 25G 9100 twentyfiveGigE1/19/2 routed up up SFP/SFP+/SFP28 N/A
71 25G 9100 twentyfiveGigE1/19/3 routed up up SFP/SFP+/SFP28 N/A
72 25G 9100 twentyfiveGigE1/19/4 routed up up SFP/SFP+/SFP28 N/A
77 25G 9100 twentyfiveGigE1/20/1 routed up up SFP/SFP+/SFP28 N/A
78 25G 9100 twentyfiveGigE1/20/2 routed up up SFP/SFP+/SFP28 N/A
79 25G 9100 twentyfiveGigE1/20/3 routed up up SFP/SFP+/SFP28 N/A
80 25G 9100 twentyfiveGigE1/20/4 routed up up SFP/SFP+/SFP28 N/A
81 25G 9100 twentyfiveGigE1/21/1 routed up up SFP/SFP+/SFP28 N/A
82 25G 9100 twentyfiveGigE1/21/2 routed up up SFP/SFP+/SFP28 N/A
83 25G 9100 twentyfiveGigE1/21/3 routed up up SFP/SFP+/SFP28 N/A
84 25G 9100 twentyfiveGigE1/21/4 routed up up SFP/SFP+/SFP28 N/A
97 25G 9100 twentyfiveGigE1/22/1 routed up up SFP/SFP+/SFP28 N/A
98 25G 9100 twentyfiveGigE1/22/2 routed up up SFP/SFP+/SFP28 N/A
99 25G 9100 twentyfiveGigE1/22/3 routed up up SFP/SFP+/SFP28 N/A
100 25G 9100 twentyfiveGigE1/22/4 routed up up SFP/SFP+/SFP28 N/A
105 25G 9100 twentyfiveGigE1/23/1 routed up up SFP/SFP+/SFP28 N/A
106 25G 9100 twentyfiveGigE1/23/2 routed up up SFP/SFP+/SFP28 N/A
107 25G 9100 twentyfiveGigE1/23/3 routed up up SFP/SFP+/SFP28 N/A
108 25G 9100 twentyfiveGigE1/23/4 routed up up SFP/SFP+/SFP28 N/A
113 25G 9100 twentyfiveGigE1/24/1 routed up up SFP/SFP+/SFP28 N/A
114 25G 9100 twentyfiveGigE1/24/2 routed up up SFP/SFP+/SFP28 N/A
115 25G 9100 twentyfiveGigE1/24/3 routed up up SFP/SFP+/SFP28 N/A
116 25G 9100 twentyfiveGigE1/24/4 routed down up SFP/SFP+/SFP28 N/A
100G 9100 hundredGigE1/49 routed up up QSFP28 or later N/A
100G 9100 hundredGigE1/50 routed up up QSFP28 or later N/A
100G 9100 hundredGigE1/51 routed up up QSFP28 or later N/A
100G 9100 hundredGigE1/52 routed up up QSFP28 or later N/A
100G 9100 hundredGigE1/53 routed up up QSFP28 or later N/A
100G 9100 hundredGigE1/54 routed up up QSFP28 or later N/A
100G 9100 hundredGigE1/55 routed up up QSFP28 or later N/A
100G 9100 hundredGigE1/56 routed up up QSFP28 or later N/A

root@sonic:~# show interfaces transceiver eeprom --dom Ethernet0
Ethernet0: SFP EEPROM detected
Connector: LC
Encoding: 64B/66B
Extended Identifier: GBIC/SFP defined by twowire interface ID
Extended RateSelect Compliance: Unspecified
Identifier: SFP/SFP+/SFP28
LengthOM3(UnitsOf10m): 7
Nominal Bit Rate(100Mbs): 255
Specification compliance:
FibreChannelTechnology: Shortwave laser w/o OFC (SN)
FibreChannelTransmissionMedia: Multimode, 50um (M5, M5E)
Vendor Date Code(YYYY-MM-DD Lot): 2019-03-12
Vendor Name: DELL
Vendor OUI: 00-17-6a
Vendor PN: W4GPP
Vendor Rev: A0
Vendor SN: CN07919193404HK
MonitorData:
RXPower: 8.1647dBm
TXBias: 131.0700mA
TXPower: 8.1647dBm
Temperature: -0.0039C
Vcc: 6.5535Volts
ThresholdData:
TempHighAlarm : -0.0039C
TempHighWarning: -0.0039C
TempLowAlarm : -0.0039C
TempLowWarning : -0.0039C
VccHighAlarm : 6.5535Volts
VccHighWarning : 6.5535Volts
VccLowAlarm : 6.5535Volts
VccLowWarning : 6.5535Volts
RxPowerHighAlarm : 8.1647dBm
RxPowerHighWarning: 8.1647dBm
RxPowerLowAlarm : 8.1647dBm
RxPowerLowWarning : 8.1647dBm
TxBiasHighAlarm : 131.0700mA
TxBiasHighWarning : 131.0700mA
TxBiasLowAlarm : 131.0700mA
TxBiasLowWarning : 131.0700mA
TxPowerHighAlarm : 8.1647dBm
TxPowerHighWarning: 8.1647dBm
TxPowerLowAlarm : 8.1647dBm
TxPowerLowWarning : 8.1647dBm

root@sonic:~#

srideepDell · 2020-01-02T15:38:54Z

Retest vsimage please

srideepDell · 2020-01-02T15:40:00Z

Retest mellanox please

srideepDell · 2020-01-08T04:03:27Z

Retest vsimage please

srideepDell · 2020-01-11T07:07:12Z

Retest vsimage please

srideepDell · 2020-01-11T09:37:31Z

Retest vsimage please

srideepDell · 2020-01-15T23:12:28Z

Retest vsimage please

device/dell/x86_64-dellemc_s5296f_c3538-r0/plugins/eeprom.py

device/dell/x86_64-dellemc_s5296f_c3538-r0/plugins/sfputil.py

platform/broadcom/sonic-platform-modules-dell/debian/platform-modules-s5296f.init

platform/broadcom/sonic-platform-modules-dell/s5296f/scripts/s5296f_platform.sh

platform/broadcom/sonic-platform-modules-dell/s5296f/scripts/sensors

- Indentation, formatting - Removing dead code Signed-off-by: Howard Persh <[email protected]>

srideepDell · 2020-01-23T19:16:36Z

Retest vsimage please

srideepDell · 2020-01-23T19:16:49Z

Retest broadcom please

* For Dell EMC S5296F, obey timeout argument in xcvrd get_transceiver_change_event() Signed-off-by: Howard Persh <[email protected]>

srideepDell · 2020-04-14T18:39:55Z

retest default please

srideepDell · 2020-04-14T18:40:11Z

retest mellanox please

srideepDell · 2020-05-04T04:41:23Z

retest default please

lgtm-com · 2020-05-04T04:59:20Z

This pull request introduces 26 alerts when merging d0af265 into 30bbbbf - view on LGTM.com

new alerts:

14 for Unused local variable
7 for Unused import
4 for Variable defined multiple times
1 for Use of the return value of a procedure

jeff-yin · 2020-07-07T06:22:07Z

Retest vsimage please

Signed-off-by: Howard Persh <[email protected]>

jeff-yin · 2020-07-08T05:27:45Z

Retest vsimage please

atanu-mandal · 2020-07-21T16:55:00Z

Retest vsimage please

device/dell/x86_64-dellemc_s5296f_c3538-r0/pmon_daemon_control.json

platform/broadcom/platform-modules-dell.mk

Signed-off-by: Howard Persh <[email protected]>

jleveque

LGTM. @lguohan to review as well, please.

jeff-yin · 2020-09-03T20:07:35Z

retest broadcom please

jeff-yin · 2020-09-04T18:37:43Z

I'm not really sure why the "broadcom" test is failing. From the Jenkins log, sonic-broadcom.bin seems to build OK, but another installer fails. It seems unrelated to these changes.

jeff-yin · 2020-09-04T18:38:39Z

retest broadcom please

jeff-yin · 2020-10-21T17:47:17Z

Hi, can this be approved/merged? Been sitting for some time now. We would like to open a follow-up PR to migrate this platform to API 2.0 after this is merged.

…onic-net#3960) Added files, driver, npu configs for the DellEMC S5296f platform

srideepDell marked this pull request as ready for review January 2, 2020 15:39

jleveque added Enhancement ➕ Platform: DellEMC labels Jan 2, 2020

srideepDell closed this Jan 11, 2020

srideepDell reopened this Jan 11, 2020

renukamanavalan requested review from zhenggen-xu, lguohan and jleveque January 16, 2020 18:39

jleveque reviewed Jan 17, 2020

View reviewed changes

device/dell/x86_64-dellemc_s5296f_c3538-r0/plugins/eeprom.py Show resolved Hide resolved

jleveque suggested changes Jan 17, 2020

View reviewed changes

[devices]: Amendments to DellEMC new platform support for DellEMC s5296f

7a28f1d

- Indentation, formatting - Removing dead code Signed-off-by: Howard Persh <[email protected]>

[devices]: Response to merge request comments

b01a123

* For Dell EMC S5296F, obey timeout argument in xcvrd get_transceiver_change_event() Signed-off-by: Howard Persh <[email protected]>

Merge branch 'master' into s5296_platform_onboarding

d0af265

[Dell EMC S5296F] Correct LGTM issues

90a82a7

Signed-off-by: Howard Persh <[email protected]>

hpersh force-pushed the s5296_platform_onboarding branch from eb3ee6a to 90a82a7 Compare July 7, 2020 21:00

qiluo-msft force-pushed the master branch from 13769f9 to 39941f0 Compare July 12, 2020 18:14

jleveque suggested changes Aug 20, 2020

View reviewed changes

device/dell/x86_64-dellemc_s5296f_c3538-r0/pmon_daemon_control.json Outdated Show resolved Hide resolved

platform/broadcom/platform-modules-dell.mk Outdated Show resolved Hide resolved

[Dell EMC S5296F] Address review comments

0710dc8

Signed-off-by: Howard Persh <[email protected]>

jleveque self-requested a review September 3, 2020 19:36

jleveque approved these changes Sep 3, 2020

View reviewed changes

jleveque merged commit 97b33e4 into sonic-net:master Oct 21, 2020

santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021

[devices]: DellEMC new platform support for DellEMC s5296f- 96x25G (s…

ba48df1

…onic-net#3960) Added files, driver, npu configs for the DellEMC S5296f platform

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[devices]: DellEMC new platform support for DellEMC s5296f- 96x25G #3960

[devices]: DellEMC new platform support for DellEMC s5296f- 96x25G #3960

srideepDell commented Jan 2, 2020

srideepDell commented Jan 2, 2020

srideepDell commented Jan 2, 2020

srideepDell commented Jan 2, 2020

srideepDell commented Jan 8, 2020

srideepDell commented Jan 11, 2020

srideepDell commented Jan 11, 2020

srideepDell commented Jan 15, 2020

srideepDell commented Jan 23, 2020

srideepDell commented Jan 23, 2020

srideepDell commented Apr 14, 2020

srideepDell commented Apr 14, 2020

srideepDell commented May 4, 2020

lgtm-com bot commented May 4, 2020

jeff-yin commented Jul 7, 2020

jeff-yin commented Jul 8, 2020

atanu-mandal commented Jul 21, 2020

jleveque left a comment

jeff-yin commented Sep 3, 2020

jeff-yin commented Sep 4, 2020

jeff-yin commented Sep 4, 2020

jeff-yin commented Oct 21, 2020

[devices]: DellEMC new platform support for DellEMC s5296f- 96x25G #3960

[devices]: DellEMC new platform support for DellEMC s5296f- 96x25G #3960

Conversation

srideepDell commented Jan 2, 2020

srideepDell commented Jan 2, 2020

srideepDell commented Jan 2, 2020

srideepDell commented Jan 2, 2020

srideepDell commented Jan 8, 2020

srideepDell commented Jan 11, 2020

srideepDell commented Jan 11, 2020

srideepDell commented Jan 15, 2020

srideepDell commented Jan 23, 2020

srideepDell commented Jan 23, 2020

srideepDell commented Apr 14, 2020

srideepDell commented Apr 14, 2020

srideepDell commented May 4, 2020

lgtm-com bot commented May 4, 2020

jeff-yin commented Jul 7, 2020

jeff-yin commented Jul 8, 2020

atanu-mandal commented Jul 21, 2020

jleveque left a comment

Choose a reason for hiding this comment

jeff-yin commented Sep 3, 2020

jeff-yin commented Sep 4, 2020

jeff-yin commented Sep 4, 2020

jeff-yin commented Oct 21, 2020