-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox]platform api support firmware install #3931
Conversation
the onie-fw-update has been postfixed with ".sh" after installed on the DUT.
Retest vs please |
Retest vsimage please |
Retest vsimage please |
…taller via using the newly introduced onie_entry
@srideepDell could you please approve this PR or you have additional feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to improve our flows one #3935 is merged
@nazariig the code that take advantage of new grub variable to resolve the sonic_installer broken issue has been merged. |
platform/mellanox/onie-fw-update
Outdated
} | ||
|
||
# ONIE entry must exist in grub config | ||
find_onie_menuentry() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephenxs Since we are already use onie_entry
, we do not need this anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please work through comments from other reviewers.
retest vsimage please |
support firmware install, including CPLD and BIOS. CPLD: cpldupdate BIOS: boot to onie and update BIOS in onie and then boot to SONiC
support firmware install, including CPLD and BIOS. CPLD: cpldupdate BIOS: boot to onie and update BIOS in onie and then boot to SONiC
support firmware install, including CPLD and BIOS. CPLD: cpldupdate BIOS: boot to onie and update BIOS in onie and then boot to SONiC
- What I did
support firmware install, including CPLD and BIOS.
- How I did it
CPLD: cpldupdate
BIOS: boot to onie and update BIOS in onie and then boot to SONiC
- How to verify it
try installing CPLD/BIOS via platform api
test-install-sonic-then-update-bios.txt
test-update-cpld-gpio.txt
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)