[config engine] For l2 preset, use admin_status: up by default #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Faryma <[email protected]>
lguohan
approved these changes
Dec 13, 2019
stepanblyschak
approved these changes
Dec 13, 2019
lguohan
pushed a commit
that referenced
this pull request
Dec 13, 2019
Updated the l2 preset config generator to specify 'admin_status': 'up' for every port by default. The use of setdefault() ensures that if port already has some admin_status set, the original value will not be overwritten. Signed-off-by: Mykola Faryma <[email protected]>
lguohan
pushed a commit
that referenced
this pull request
Dec 13, 2019
Updated the l2 preset config generator to specify 'admin_status': 'up' for every port by default. The use of setdefault() ensures that if port already has some admin_status set, the original value will not be overwritten. Signed-off-by: Mykola Faryma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma [email protected]
- What I did
Updated the l2 preset config generator to specify 'admin_status': 'up' for every port by default.
The use of setdefault() ensures that if port already has some admin_status set, the original value will not be overwritten.
- How I did it
- How to verify it
sonic-cfggen -H -p -k $HWSKU --preset l2
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)