Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[database] save configuration after DB migration" #3199

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Jul 22, 2019

Reverts #3143

This change caused a regression in sonic to sonic upgrade:

The updategraph service depends on database service. upgradegraph will convert minigraph if config_db.json is missing upon the first boot. If we save db in database service, then the config_db.json will exist even it is an empty database, and subsequently causing updategraph service to skip loading minigraph.

To guarantee saving database after warm reboot, we need to add save to warm boot finalize service.

@yxieca yxieca merged commit 401f704 into master Jul 22, 2019
@yxieca yxieca deleted the revert-3143-save_db branch July 22, 2019 21:13
yxieca added a commit that referenced this pull request Jul 23, 2019
StormLiangMS pushed a commit that referenced this pull request Mar 14, 2024
…atically (#18364)

Why I did it
src/sonic-utilities

* 45c44094 - (HEAD -> 202305, origin/202305) [config] Add Table hard dependency check (#3159) (10 hours ago) [jingwenxie]
* 8bde9cf7 - Skip the validation of action in acl-loader if capability table in STATE_DB is empty (#3199) (20 hours ago) [bingwang-ms]
How I did it
How to verify it
mssonicbld added a commit that referenced this pull request Mar 15, 2024
…atically (#18332)

#### Why I did it
src/sonic-utilities
```
* c68f4b16 - (HEAD -> 202311, origin/202311) Skip the validation of action in acl-loader if capability table in STATE_DB is empty (#3199) (3 days ago) [bingwang-ms]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Mar 28, 2024
…atically (#18240)

#### Why I did it
src/sonic-utilities
```
* bdc57206 - (HEAD -> master, origin/master, origin/HEAD) Revert "Fix for Switch Port Modes and VLAN CLI Enhancement (#3108)" (#3246) (89 minutes ago) [jingwenxie]
* e35452b7 - Modify "show interface transceiver status" CLI to show SW cmis state (#3238) (2 days ago) [mihirpat1]
* 04a33e1f - Add "state" field in CONFIG_DB a toggle of the fabric port monitor feature (#2932) (2 days ago) [jfeng-arista]
* 3c489ba5 - Enhance route-check for multi-asic platforms (#3216) (5 days ago) [Deepak Singhal]
* c149e48b - [chassis] Add chassis support for CLI "config qos reload" (#3233) (6 days ago) [wenyiz2021]
* d8541add - Update port2alias (#3217) (8 days ago) [abdosi]
* d4688a8f - [graceful reboot] Add the pre_reboot_hook script execution, add the watchdog arm before the reboot (#3203) (8 days ago) [Vadym Hlushko]
* 125f36f3 - [ipintutil]Handle exception in show ip interfaces command (#3182) (10 days ago) [Sudharsan Dhamal Gopalarathnam]
* 9d532017 - [chassis][show-runningconfig] Fix the show runningconfiguration all issue on the Supervisor (#3194) (2 weeks ago) [Marty Y. Lok]
* 1a9261ce - [Techsupport]Handle SAI kv pair if present in sai common profile (#3196) (2 weeks ago) [Sudharsan Dhamal Gopalarathnam]
* 7466dc4a - Skip the validation of action in acl-loader if capability table in STATE_DB is empty (#3199) (2 weeks ago) [bingwang-ms]
* b879b658 - [Bug] Fix fw_setenv illegel character issue (#3201) (3 weeks ago) [xumia]
* 0b41a560 - [config] Add YANG alerting for override (#3188) (3 weeks ago) [jingwenxie]
* 24683b0c - [show] multi-asic show running test residue (#3198) (3 weeks ago) [jingwenxie]
* 995a797a - CLI to skip polling for periodic information for a port in DomInfoUpdateTask thread (#3187) (3 weeks ago) [mihirpat1]
* 9aa9eaa5 - [config] Add Table hard dependency check (#3159) (3 weeks ago) [jingwenxie]
* 5f0ffcca - [fast/warm-reboot] Put ERR message in syslog when a failure is seen (#3186) (4 weeks ago) [Vaibhav Hemant Dixit]
* 92220dcf - Fix for Switch Port Modes and VLAN CLI Enhancement (#3108) (4 weeks ago) [Saba Akram]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jun 26, 2024
…lly (#19394)

#### Why I did it
src/sonic-swss
```
* d20294a3 - (HEAD -> master, origin/master, origin/HEAD) Remove buffer maximum parameter table when the port is removed (#3199) (9 hours ago) [Stephen Sun]
* 1b87ce91 - Update oper_status of LAG_TABLE in state_db (#3195) (9 hours ago) [super-jiying]
```
#### How I did it
#### How to verify it
#### Description for the changelog
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
…lly (sonic-net#19394)

#### Why I did it
src/sonic-swss
```
* d20294a3 - (HEAD -> master, origin/master, origin/HEAD) Remove buffer maximum parameter table when the port is removed (sonic-net#3199) (9 hours ago) [Stephen Sun]
* 1b87ce91 - Update oper_status of LAG_TABLE in state_db (sonic-net#3195) (9 hours ago) [super-jiying]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jul 31, 2024
…lly (#19743)

#### Why I did it
src/sonic-swss
```
* d04f5f8b - (HEAD -> 202405, origin/202405) Remove buffer maximum parameter table when the port is removed (#3199) (7 hours ago) [Stephen Sun]
* 8962c7b4 - Support allocate buffer pool based on ratio (#3201) (7 hours ago) [Stephen Sun]
```
#### How I did it
#### How to verify it
#### Description for the changelog
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
…lly (sonic-net#19394)

#### Why I did it
src/sonic-swss
```
* d20294a3 - (HEAD -> master, origin/master, origin/HEAD) Remove buffer maximum parameter table when the port is removed (sonic-net#3199) (9 hours ago) [Stephen Sun]
* 1b87ce91 - Update oper_status of LAG_TABLE in state_db (sonic-net#3195) (9 hours ago) [super-jiying]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants