[docker]: get hostname from config db instead of minigraph #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minigraph may not be always available on the some system configuration. Should use config db as the source of truth.
lguohan
requested review from
jleveque and
qiluo-msft
and removed request for
jleveque
msosyak
reviewed
Jun 13, 2019
jleveque
approved these changes
Jun 13, 2019
|
Retest vs please |
qiluo-msft
approved these changes
Jun 13, 2019
|
retest vs please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minigraph may not be always available on the some system configuration.
Should use config db as the source of truth.
- What I did
fix issue #3003
- How I did it
read the hostname from config db instead of minigraph
- How to verify it
tested on virtual switch.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)