[sonic-platform-modules-dell] Graceful platform reboot #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commit addresses the graceful unmounting of file system and graceful shutdown of dockers before calling a cold reboot which will cause a power cycle of SSD. This ensures orderly shutdown and no corruption of files systems because of the power cycle to SSD. This commit will use the existing systemd-reboot service scripts and override the configuration to do cold reboot for S6100 and Z9100. Unit tested the fix and graceful shutdown of file system and dockers are done with cold reboot. Signed-off-by: Harish Venkatraman <[email protected]>
lguohan
reviewed
May 18, 2019
platform/broadcom/sonic-platform-modules-dell/z9100/scripts/override.conf
Show resolved
Hide resolved
|
can you provide the test log? since the request is also to 201803 branch, can you provide test log on that branch as well? |
I will provide the test cases and test logs for 201803 |
|
Attaching test cases and unit test log. |
|
can you resolve the conflict? |
done. |
|
retest this please |
lguohan
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commit addresses the graceful unmounting of file
system and graceful shutdown of dockers before calling a
cold reboot which will cause a power cycle of SSD. This ensures
orderly shutdown and no potential corruption of files systems because
of the power cycle to SSD.
This commit will use the existing systemd-reboot service scripts
and override the configuration to do cold reboot for S6100 and
Z9100.
Unit tested the fix and graceful shutdown of file system and
dockers are done with cold reboot.
Signed-off-by: Harish Venkatraman [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)