-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[evpn]: Change frr template to support evpn #2838
Conversation
- Add extension "do" action to jinja environment in sonic-cfggen - Change frr.conf.j2 to support evpn Signed-off-by: zegan <[email protected]>
Signed-off-by: zegan <[email protected]>
91a33cc
to
6e716ce
Compare
Signed-off-by: zegan <[email protected]>
{% if neighbor_addr | ipv4 %} | ||
address-family ipv4 | ||
{% if DEVICE_METADATA['localhost']['type'] == 'ToRRouter' %} | ||
neighbor {{ neighbor_addr }} allowas-in 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you describe the circumstances, setup and requirements that need the allowas-in so that I can better understand? Especially under address-family ipv4, allowas-in shouldn't be needed but I'm looking forward to your explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is needed as the tor asn is re-used for different clusters.
@@ -79,6 +79,62 @@ route-map FROM_BGP_SPEAKER_V4 permit 10 | |||
! | |||
route-map TO_BGP_SPEAKER_V4 deny 10 | |||
! | |||
{% block vnet_bgp_instance %} | |||
{% if VNET is defined %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does this VNET comes from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Azure/SONiC/blob/master/doc/vxlan/Vxlan_hld.md#212-vnetinterface-table
VNET comes from the ConfigDB
need minigraph.py change, also need to add sample configuration in the sonic-cfggen unit test code coverage. |
please switch this to the bgpd.conf |
@@ -229,7 +229,7 @@ def main(): | |||
paths = ['/', '/usr/share/sonic/templates', os.path.dirname(template_file)] | |||
loader = jinja2.FileSystemLoader(paths) | |||
|
|||
env = jinja2.Environment(loader=loader, trim_blocks=True) | |||
env = jinja2.Environment(loader=loader, trim_blocks=True, extensions=['jinja2.ext.do']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this jinja2.ext.do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a temp variable to store the interfaces that belong to the specified vnet. In this situation, the "do" action will be needed.
…atically (#16199) #### Why I did it src/sonic-utilities ``` * d69432d1 - (HEAD -> 202211, origin/202211) [202211][db_migrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->2211 upgrade + fast-reboot. Add UT. (#2838) (34 hours ago) [Vadym Hlushko] ``` #### How I did it #### How to verify it #### Description for the changelog
Signed-off-by: zegan [email protected]