Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evpn]: Change frr template to support evpn #2838

Closed
wants to merge 3 commits into from

Conversation

Pterosaur
Copy link
Contributor

  • Add extension "do" action to jinja environment in sonic-cfggen
  • Change frr.conf.j2 to support evpn

Signed-off-by: zegan [email protected]

- Add extension "do" action to jinja environment in sonic-cfggen
- Change frr.conf.j2 to support evpn

Signed-off-by: zegan <[email protected]>
@Pterosaur Pterosaur force-pushed the evpn branch 2 times, most recently from 91a33cc to 6e716ce Compare April 30, 2019 10:45
{% if neighbor_addr | ipv4 %}
address-family ipv4
{% if DEVICE_METADATA['localhost']['type'] == 'ToRRouter' %}
neighbor {{ neighbor_addr }} allowas-in 1
Copy link
Collaborator

@nikos-github nikos-github Apr 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe the circumstances, setup and requirements that need the allowas-in so that I can better understand? Especially under address-family ipv4, allowas-in shouldn't be needed but I'm looking forward to your explanation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed as the tor asn is re-used for different clusters.

@@ -79,6 +79,62 @@ route-map FROM_BGP_SPEAKER_V4 permit 10
!
route-map TO_BGP_SPEAKER_V4 deny 10
!
{% block vnet_bgp_instance %}
{% if VNET is defined %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this VNET comes from?

Copy link
Contributor Author

@Pterosaur Pterosaur May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan
Copy link
Collaborator

lguohan commented May 6, 2019

need minigraph.py change, also need to add sample configuration in the sonic-cfggen unit test code coverage.

@lguohan
Copy link
Collaborator

lguohan commented May 9, 2019

please switch this to the bgpd.conf

@@ -229,7 +229,7 @@ def main():
paths = ['/', '/usr/share/sonic/templates', os.path.dirname(template_file)]
loader = jinja2.FileSystemLoader(paths)

env = jinja2.Environment(loader=loader, trim_blocks=True)
env = jinja2.Environment(loader=loader, trim_blocks=True, extensions=['jinja2.ext.do'])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this jinja2.ext.do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Azure/sonic-buildimage/pull/2838/files#diff-4c9b3f6e87e24e7256cd7abf5e0da806R97

We need a temp variable to store the interfaces that belong to the specified vnet. In this situation, the "do" action will be needed.

@Pterosaur Pterosaur closed this May 9, 2019
@Pterosaur Pterosaur reopened this May 9, 2019
@Pterosaur Pterosaur closed this May 21, 2019
mssonicbld added a commit that referenced this pull request Aug 19, 2023
…atically (#16199)

#### Why I did it
src/sonic-utilities
```
* d69432d1 - (HEAD -> 202211, origin/202211) [202211][db_migrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->2211 upgrade + fast-reboot. Add UT. (#2838) (34 hours ago) [Vadym Hlushko]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants