[syncd.sh] Don't stop sxdkernel during warm shutdown on Mellanox plat… #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form /etc/init.d/sxdkernel stop may take up to 15 sec which has impact on control plane downtime Signed-off-by: Stepan Blyschak <[email protected]>
yxieca
reviewed
Feb 15, 2019
There was a problem hiding this comment.
@stepanblyschak does Mellanox platform support fast reboot at all? Your change effectively stopped module removal if the reboot type is fast reboot. If you plan to support fast reboot on Mellanox platform. This is a change you didn't mention in your test section.
|
@yxieca Fast reboot is supported on mellanox. In case of fast reboot WARM_BOOT variable is false so it still stops the module - this is how it was before the change, so I don't understand how this change affects fast reboot |
|
@stepanblyschak oh my bad. I was looking at change in the mindset of warm-reboot script. The comments explains all and your test is sufficient. |
yxieca
approved these changes
Feb 15, 2019
|
Made to 201811 branch on 2/21/2019 |
yxieca
pushed a commit
that referenced
this pull request
Feb 21, 2019
…form (#2572) /etc/init.d/sxdkernel stop may take up to 15 sec which has impact on control plane downtime Signed-off-by: Stepan Blyschak <[email protected]>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…form (sonic-net#2572) /etc/init.d/sxdkernel stop may take up to 15 sec which has impact on control plane downtime Signed-off-by: Stepan Blyschak <[email protected]>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…form (sonic-net#2572) /etc/init.d/sxdkernel stop may take up to 15 sec which has impact on control plane downtime Signed-off-by: Stepan Blyschak <[email protected]>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…form (sonic-net#2572) /etc/init.d/sxdkernel stop may take up to 15 sec which has impact on control plane downtime Signed-off-by: Stepan Blyschak <[email protected]>
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 1, 2023
Update sonic-utilities submodule pointer to include the following: 3bc2bc6 [Mellanox][202205] Change severity to NOTICE in Mellanox buffer migrator when unable to fetch DEVICE_METADATA due to empty CONFIG_DB during initialization (#2570) e1c8243 [202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (#2572) 9f2984a [202205] Fix issue: unconfigured PGs are displayed in watermarkstat (#2568) f7988b0 [202205] [timer.unit.j2] use wanted-by in timer unit (#2561) f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (#2565) 67cbb15 [202205]Fixes 12170: Delete subinterface and recreate the subinterface in default-vrf (#2564) 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (#2562) Signed-off-by: dprital <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…form
/etc/init.d/sxdkernel stop may take up to 20 sec which has impact on
control plane downtime
Signed-off-by: Stepan Blyschak [email protected]
- What I did
Don't stop sxdkernel during warm shutdown on Mellanox platform since it may take 15-20 sec to stop
- How I did it
Place sxdkernel stop under
if [[ x"$WARM_BOOT" != x"warm" ]]statement- How to verify it
Run warm reboot 100 times with and without this change:
Without this change: 1 of 10 runs LAG on neighbor may go down
With this change: After 100 reboots LAG never went down
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)