Build python3.6 deb packages and install them into docker-snmp-sv2 #245

qiluo-msft · 2017-02-03T00:33:57Z

No description provided.

lguohan · 2017-02-03T12:24:26Z

src/python3/Makefile

+
+$(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% :
+	## Obtaining the python3
+	wget http://http.debian.net/debian/pool/main/p/$(PYTHON_PNAME)/$(PYTHON_PNAME)_$(PYTHON_VER).orig.tar.xz -O $(PYTHON_PNAME)_$(PYTHON_VER).orig.tar.xz


python3.6 is in stretch meaning there will be updates, probably we should upload to the azure storage and download from there. #Resolved

stcheng · 2017-02-04T03:47:26Z

dockers/docker-snmp-sv2/Dockerfile.j2

+# install libsnmp30 dependencies
+# install dependencies for sonic-cfggen
+# install libpython3.6-dev and pip dependencies
+# TODO: remove libpython3.6-dev, its and pip's dependencies if we can get pip3 directly


what is 'its'? #Resolved

libpython3.6-dev's (dependencies)

In reply to: 99458291 [](ancestors = 99458291)

stcheng · 2017-02-04T03:47:43Z

dockers/docker-snmp-sv2/Dockerfile.j2

-    ldconfig && \
-    cd .. && rm -rf Python-3.5.2 && rm Python-3.5.2.tgz && \
-    pip3 install --no-cache-dir /python-wheels/*py3*.whl hiredis && \
+# clean up


this comment shall be moved lower? #WontFix

All these comments are related to below single RUN statement. It's difficult to comment near the exact line, any idea?

In reply to: 99458299 [](ancestors = 99458299)

One option: you could split the RUN statement into three RUN statements, update, install and clean up. #Resolved

You are right. Both options have the same effect. The merging option is kind of manual 'docker squash', which remove the unnecessary intermediate layer storage from docker image's point of view. In future when 'docker squash' becomes mature, we can prevent this situation.

In reply to: 99679265 [](ancestors = 99679265)

we are using docker --squash now, we can seperate into different RUNs now. #Resolved

stcheng · 2017-02-04T03:49:27Z

rules/python3.mk

@@ -0,0 +1,38 @@
+# python3.5.2+


3.6.0-1? #Resolved

'+' indicates any later version

In reply to: 99458337 [](ancestors = 99458337)

Yeah I know, but why not using a fixed version? #Resolved

snmpagent depends on python3.5.2+. Currently 3.6.0-1 was the only backport-able version for Debian Jessie fulfill our requirement. So I keep the filename and the comment as accurate as possible, in order not to mislead that 3.6.0-1 is the lowest require version.

In reply to: 99676879 [](ancestors = 99676879)

I agree with shuotian, should remove 3.5.2+. we specify 3.6.0-1 that what we have validated. For example, we might use something in this package that is only available for 3.6.0-1, then 3.5.2 is no longer supported. But the questions is since we have no plan to validate/test 3.5.2 in the future, when are we gong to know it will 3.5.2. #Resolved

Removed.

In reply to: 99899345 [](ancestors = 99899345)

stcheng

Thanks for the answers

lguohan · 2017-02-08T02:15:15Z

conflict with recent commit, can you resolve the conflict? #Resolved

Squashed commit of the following: commit dfa48862586c6c56fc7425aeb802f67f3245077b Merge: 4a70bde f2eed8f Author: Qi Luo <[email protected]> Date: Sun Jan 29 20:38:22 2017 +0000 Merge branch 'github_master' into qiluo/python36 commit 4a70bde906bff141bcb1d6578826c009f9bb9168 Merge: 00ec4e1 9b940c3 Author: Qi Luo <[email protected]> Date: Sun Jan 22 23:56:13 2017 +0000 Merge branch 'github_master' into qiluo/python36 commit 00ec4e1a9295dd9420da492be60a297d55bbdb5a Author: Qi Luo <[email protected]> Date: Sun Jan 22 23:40:23 2017 +0000 Fix python3 command commit 04daf5826dea73fa68a7c0ad6799e5f0fdafdded Author: Qi Luo <[email protected]> Date: Sat Jan 21 02:16:48 2017 +0000 Remove build shell script commit 5988810c4537f5a3350fc3d01e399ea25006e191 Author: Qi Luo <[email protected]> Date: Sat Jan 21 02:16:27 2017 +0000 Refine python3 build.sh commit 1c4ba20ef944131e5d8c35d08f9454024d9eea14 Author: Qi Luo <[email protected]> Date: Sat Jan 21 02:15:08 2017 +0000 Add missing supervisor commit 70369a596099cbebb12a1052bb3dc322cb72caf1 Author: Qi Luo <[email protected]> Date: Fri Jan 20 23:23:52 2017 +0000 Fix DERIVED_TARGETS and cp command commit 5f52e884620c59239a55102fc1ce988ed85fe13d Author: Qi Luo <[email protected]> Date: Fri Jan 20 06:37:13 2017 +0000 Reduce docker image size commit 3985310970bc8f8ab0b84358cef61834153a69fd Author: Qi Luo <[email protected]> Date: Fri Jan 20 03:50:30 2017 +0000 snmp docker images builds with python debs commit 0c340ec460b7172fe3662371f51bfb13cb7dacc5 Author: Qi Luo <[email protected]> Date: Thu Jan 12 02:50:57 2017 +0000 (comment) commit 0c2353f6c93678b00a01ea2104e145bb822ad542 Author: Qi Luo <[email protected]> Date: Thu Jan 12 00:53:32 2017 +0000 (comment) commit 22836d960e97f070b99543f255f0a61ccdcfb1c8 Author: Qi Luo <[email protected]> Date: Wed Jan 11 23:12:55 2017 +0000 Fix bug: dpkg and force install commit d26da9607af702b8029a7b9aaf9f73ec1ae7734d Author: Qi Luo <[email protected]> Date: Wed Jan 11 22:43:09 2017 +0000 Remove wget timestamp option commit 363aeba0aaf5bf53f557385355d34c3824a4a778 Author: Qi Luo <[email protected]> Date: Wed Jan 11 22:18:22 2017 +0000 Build debian package python3.6

lguohan · 2017-02-08T06:00:51Z

dockers/docker-snmp-sv2/Dockerfile.j2

+RUN apt-get update && apt-get install -y supervisor \
+            libperl5.20 libpci3 libwrap0 \
+            libexpat1-dev \
+            python-lxml python-jinja2 python-netaddr python-ipaddr python-yaml \


python-lxml python-jinja2 python-netaddr python-ipaddr python-yaml [](start = 12, length = 67)

we should remove these now, included in the sonic-config-engine #Resolved

lguohan · 2017-02-08T06:01:21Z

dockers/docker-snmp-sv2/Dockerfile.j2

-
+# install supervisor
+# install libsnmp30 dependencies
+# install dependencies for sonic-cfggen


remove this #Resolved

lguohan · 2017-02-08T06:02:28Z

dockers/docker-snmp-sv2/Dockerfile.j2

+            libperl5.20 libpci3 libwrap0 \
+            libexpat1-dev \
+            python-lxml python-jinja2 python-netaddr python-ipaddr python-yaml \
+            curl gcc && \


cc [](start = 18, length = 2)

do we need gcc? #Resolved

It is needed to install pip by 'get_pip.py'

In reply to: 99996933 [](ancestors = 99996933)

lguohan

remove packages for docker-config-engine

stcheng · 2017-02-09T00:50:32Z

When merging, please note to re-format the comments on the github website. Otherwise it will contain too much logs.

lguohan · 2017-02-09T05:13:52Z

sairedis * 248a095 2018-11-07 | Add best candidate search for acl table (sonic-net#371) [Kamil Cudnik] * d1e26c3 2018-11-07 | Ignore order when compare QOS MAP list entries (sonic-net#372) [Kamil Cudnik] * e8df347 2018-11-05 | Add best candidate search for router interface using tunnel term tabl… (sonic-net#370) [Kamil Cudnik] * 8ae173b 2018-11-01 | Refactor saidump graph generator (sonic-net#367) [Kamil Cudnik] common * 2a37c5c 2018-11-07 | Add system warm-reboot check in WarmRestart class (sonic-net#246) (HEAD, origin/master, origin/HEAD) [zhenggen-xu] * fb082b5 2018-11-06 | Fix ProducerStateTable::clear() to clear StateHash properly (sonic-net#244) [Taoyu Li] * 0ee636b 2018-11-05 | Remove local googletest submodule and link with system gtest (sonic-net#245) [Qi Luo] * b56ffba 2018-10-31 | Add NEIGH_RESTORE_TABLE in stateDB (sonic-net#243) [zhenggen-xu] * b58c69d 2018-10-28 | swss-common: add op 'create' case to avoid flush immediately (sonic-net#219) [Dong Zhang] swss * afdcf34 2018-11-12 | Support neighsyncd system warmreboot. (sonic-net#661) (HEAD, origin/master, origin/HEAD) [zhenggen-xu] * f380685 2018-11-09 | Routing-stack warm-reboot feature. (sonic-net#602) [Rodny Molina] * 9fbcb60 2018-11-09 | Add warm-reboot mode for teammgrd (sonic-net#678) [pavel-shirshov] * 8c60787 2018-11-09 | Don't add loopback ip2me route again if already configured (sonic-net#656) [Jipan Yang] * 6eb1613 2018-11-08 | [test]: Add interface IPv6 add/remove test case (sonic-net#677) [Shuotian Cheng] * 5de5054 2018-11-07 | [vrfmgrd]: Support VNET setting (sonic-net#657) [Marian Pritsak] * f666011 2018-11-06 | [teammgrd]: Add retry logic when enslaving member port into team (sonic-net#669) [Shuotian Cheng] * 36e304d 2018-11-05 | [vstest]: print output when runcmd returns error (sonic-net#672) [lguohan] * aede5d4 2018-11-05 | [test]: Fix clean up wrong interface IP (sonic-net#673) [Shuotian Cheng] * aeceaca 2018-11-02 | [portmgrd]: portmgrd shall be responsible for all ports update (sonic-net#668) [Shuotian Cheng] * 5796e54 2018-11-02 | Orchagent warm restart data restore requires three iterations (sonic-net#670) [Jipan Yang] * 15a2299 2018-11-01 | [vlanmgrd]: Do not bring up VLAN members by default (sonic-net#667) [Shuotian Cheng] * 44a4460 2018-11-01 | [test]: Clean up LAGs after finishing the test (sonic-net#666) [Shuotian Cheng] Signed-off-by: Guohan Lu <[email protected]>

sairedis * 248a095 2018-11-07 | Add best candidate search for acl table (#371) [Kamil Cudnik] * d1e26c3 2018-11-07 | Ignore order when compare QOS MAP list entries (#372) [Kamil Cudnik] * e8df347 2018-11-05 | Add best candidate search for router interface using tunnel term tabl… (#370) [Kamil Cudnik] * 8ae173b 2018-11-01 | Refactor saidump graph generator (#367) [Kamil Cudnik] common * 2a37c5c 2018-11-07 | Add system warm-reboot check in WarmRestart class (#246) (HEAD, origin/master, origin/HEAD) [zhenggen-xu] * fb082b5 2018-11-06 | Fix ProducerStateTable::clear() to clear StateHash properly (#244) [Taoyu Li] * 0ee636b 2018-11-05 | Remove local googletest submodule and link with system gtest (#245) [Qi Luo] * b56ffba 2018-10-31 | Add NEIGH_RESTORE_TABLE in stateDB (#243) [zhenggen-xu] * b58c69d 2018-10-28 | swss-common: add op 'create' case to avoid flush immediately (#219) [Dong Zhang] swss * afdcf34 2018-11-12 | Support neighsyncd system warmreboot. (#661) (HEAD, origin/master, origin/HEAD) [zhenggen-xu] * f380685 2018-11-09 | Routing-stack warm-reboot feature. (#602) [Rodny Molina] * 9fbcb60 2018-11-09 | Add warm-reboot mode for teammgrd (#678) [pavel-shirshov] * 8c60787 2018-11-09 | Don't add loopback ip2me route again if already configured (#656) [Jipan Yang] * 6eb1613 2018-11-08 | [test]: Add interface IPv6 add/remove test case (#677) [Shuotian Cheng] * 5de5054 2018-11-07 | [vrfmgrd]: Support VNET setting (#657) [Marian Pritsak] * f666011 2018-11-06 | [teammgrd]: Add retry logic when enslaving member port into team (#669) [Shuotian Cheng] * 36e304d 2018-11-05 | [vstest]: print output when runcmd returns error (#672) [lguohan] * aede5d4 2018-11-05 | [test]: Fix clean up wrong interface IP (#673) [Shuotian Cheng] * aeceaca 2018-11-02 | [portmgrd]: portmgrd shall be responsible for all ports update (#668) [Shuotian Cheng] * 5796e54 2018-11-02 | Orchagent warm restart data restore requires three iterations (#670) [Jipan Yang] * 15a2299 2018-11-01 | [vlanmgrd]: Do not bring up VLAN members by default (#667) [Shuotian Cheng] * 44a4460 2018-11-01 | [test]: Clean up LAGs after finishing the test (#666) [Shuotian Cheng] Signed-off-by: Guohan Lu <[email protected]>

* Added support to configure fec mode on interface * Modified checks to address comments

…nox SN2740 platform (sonic-net#245)

* build syncd-vs and syncd-vs-dbg package build syncd-vs package without vendor SAI package remove vssyncd package as its build still rely on a vendor SAI package. * install sai headers in libsaivs-dev package

* 6aa8d00 2021-11-12 | marvell-armhf]: add kconfig force inclusion for CONFIG_ARCH_NR_GPIO (sonic-net#245) (HEAD, origin/master, origin/HEAD) [dflynn-Nokia] * 39c7d18 2021-11-06 | [arm64]: add kconfig force inclusion for COMPAT_VSDO [Guohan Lu] * fafaaea 2021-11-06 | [backport] kernel-compat-always-include-linux-compat.h-from-net-compat.patch [Guohan Lu] * 6ac9b48 2021-10-19 | [ci]: use native arm64/armhf pool to build kernel [Guohan Lu] Signed-off-by: Guohan Lu <[email protected]>

* 6aa8d00 2021-11-12 | marvell-armhf]: add kconfig force inclusion for CONFIG_ARCH_NR_GPIO (#245) (HEAD, origin/master, origin/HEAD) [dflynn-Nokia] * 39c7d18 2021-11-06 | [arm64]: add kconfig force inclusion for COMPAT_VSDO [Guohan Lu] * fafaaea 2021-11-06 | [backport] kernel-compat-always-include-linux-compat.h-from-net-compat.patch [Guohan Lu] * 6ac9b48 2021-10-19 | [ci]: use native arm64/armhf pool to build kernel [Guohan Lu] Signed-off-by: Guohan Lu <[email protected]>

c2aac75 [SFP-Refactor] Fix LP mode API issue (#247) dba17c8 Firmware upgrade CLI support for QSFP-DD transceivers (#244) cd69212 [SFP-Refactor] Implement CMIS Low Power mode (#237) 9cea07f Fix RegGroupField decode (#245) 6ae1909 Add CMIS QSFP support (#246) c1f317d Gracefully handle CMIS APIs for passive modules (#238) ec7335d fix for firmware functions (#243) cf2ebe9 Fix RegBitField decode/encode (#242) ef4f2c6 Fix SFP_CABLE_TECH_FIELD (#240) e118644 remove time counting message in functions because function running time could be difficult to predict in unit tests (#241) Signed-off-by: Prince George <[email protected]>

…onic-net#245) The bullseye kernel defaults the CONFIG_ARCH_NR_GPIO config option for marvell-armhf to 1024 which prevents the value from being overridden to 0. This commit uses the new force_inclusion file to override the value without performing any additional checks.

#18372) #### Why I did it src/linkmgrd ``` * dd61844 - (HEAD -> master, origin/master, origin/HEAD) [active-standby] reset mux probing backoff factor in link flaps (#245) (5 hours ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog

#18432) #### Why I did it src/linkmgrd ``` * 27aed40 - (HEAD -> 202311, origin/202311) [active-standby] reset mux probing backoff factor in link flaps (#245) (4 hours ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog

#18585) #### Why I did it src/linkmgrd ``` * 7706c2c - (HEAD -> 202305, origin/202305) [active-standby] reset mux probing backoff factor in link flaps (#245) (2 days ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog

…lly (#19325) #### Why I did it src/sonic-gnmi ``` * a610784 - (HEAD -> master, origin/master, origin/HEAD) Improve timeout for GNMI dbus service (#265) (3 days ago) [ganglv] * b1c90c9 - Add unit test for vlan interface (#264) (6 days ago) [ganglv] * fbf0234 - Add unit test for syslog config (#263) (6 days ago) [ganglv] * 047fc29 - Add unit test for portchannel interface (#262) (6 days ago) [ganglv] * 52dd8e7 - Add unit test for pg headroom (#261) (6 days ago) [ganglv] * 8a10d9f - Add unit test for pfcwd status (#260) (6 days ago) [ganglv] * 65a43bc - Add unit test for pfcwd interval (#259) (6 days ago) [ganglv] * 0bbb9ef - Add unit test for ntp (#258) (7 days ago) [ganglv] * e5c43a4 - Add unit test for monitor config (#257) (7 days ago) [ganglv] * 8a8881e - Add unit test for mmu dynamic threshold (#256) (7 days ago) [ganglv] * 76857df - Add unit test for lo interface (#255) (7 days ago) [ganglv] * c35c69d - Add unit test for k8s config (#254) (8 days ago) [ganglv] * dd0bdcf - Add unit test for IPV6 (#253) (8 days ago) [ganglv] * 9a1133f - Add unit test for incremental qos (#252) (8 days ago) [ganglv] * 9bf7969 - Add unit test for eth interface (#251) (8 days ago) [ganglv] * 2e1eb05 - Add unit test for ECN config (#250) (8 days ago) [ganglv] * 56f17eb - Add unit test for dynamic ACL (#249) (8 days ago) [ganglv] * 388eba8 - Add unit test for DHCP relay (#245) (10 days ago) [ganglv] * fd2fdf6 - Add unit test for CACL (#243) (11 days ago) [ganglv] ``` #### How I did it #### How to verify it #### Description for the changelog

…lly (sonic-net#19325) #### Why I did it src/sonic-gnmi ``` * a610784 - (HEAD -> master, origin/master, origin/HEAD) Improve timeout for GNMI dbus service (sonic-net#265) (3 days ago) [ganglv] * b1c90c9 - Add unit test for vlan interface (sonic-net#264) (6 days ago) [ganglv] * fbf0234 - Add unit test for syslog config (sonic-net#263) (6 days ago) [ganglv] * 047fc29 - Add unit test for portchannel interface (sonic-net#262) (6 days ago) [ganglv] * 52dd8e7 - Add unit test for pg headroom (sonic-net#261) (6 days ago) [ganglv] * 8a10d9f - Add unit test for pfcwd status (sonic-net#260) (6 days ago) [ganglv] * 65a43bc - Add unit test for pfcwd interval (sonic-net#259) (6 days ago) [ganglv] * 0bbb9ef - Add unit test for ntp (sonic-net#258) (7 days ago) [ganglv] * e5c43a4 - Add unit test for monitor config (sonic-net#257) (7 days ago) [ganglv] * 8a8881e - Add unit test for mmu dynamic threshold (sonic-net#256) (7 days ago) [ganglv] * 76857df - Add unit test for lo interface (sonic-net#255) (7 days ago) [ganglv] * c35c69d - Add unit test for k8s config (sonic-net#254) (8 days ago) [ganglv] * dd0bdcf - Add unit test for IPV6 (sonic-net#253) (8 days ago) [ganglv] * 9a1133f - Add unit test for incremental qos (sonic-net#252) (8 days ago) [ganglv] * 9bf7969 - Add unit test for eth interface (sonic-net#251) (8 days ago) [ganglv] * 2e1eb05 - Add unit test for ECN config (sonic-net#250) (8 days ago) [ganglv] * 56f17eb - Add unit test for dynamic ACL (sonic-net#249) (8 days ago) [ganglv] * 388eba8 - Add unit test for DHCP relay (sonic-net#245) (10 days ago) [ganglv] * fd2fdf6 - Add unit test for CACL (sonic-net#243) (11 days ago) [ganglv] ``` #### How I did it #### How to verify it #### Description for the changelog

lguohan reviewed Feb 3, 2017

View reviewed changes

lguohan approved these changes Feb 3, 2017

View reviewed changes

stcheng suggested changes Feb 4, 2017

View reviewed changes

stcheng approved these changes Feb 7, 2017

View reviewed changes

qiluo-msft added 3 commits February 8, 2017 04:40

(reformat)

80d2923

Download python3 source from azure storage mirror

c77e64b

lguohan reviewed Feb 8, 2017

View reviewed changes

lguohan requested changes Feb 8, 2017

View reviewed changes

qiluo-msft added 2 commits February 8, 2017 19:24

Remove unused dependencies

785a242

(comment)

257f091

lguohan approved these changes Feb 9, 2017

View reviewed changes

qiluo-msft merged commit 822680d into sonic-net:master Feb 9, 2017

qiluo-msft deleted the qiluo/buildpython36 branch February 9, 2017 06:02

lguohan mentioned this pull request Nov 12, 2018

[submodules]: update swss/sairedis/common for warmboot #2248

Merged

Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019

Added support to configure fec mode on interface (sonic-net#245)

5192b55

* Added support to configure fec mode on interface * Modified checks to address comments

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

[qos/buffer]: Add QoS and buffer configuration sample files for Mella…

179daac

…nox SN2740 platform (sonic-net#245)

lguohan mentioned this pull request Nov 14, 2021

[submodule]: update sonic-linux-kernel #9254

Merged

5 tasks

vdahiya12 mentioned this pull request May 31, 2022

[sonic-platform-common][sonic-platform-daemons]submodule update #10993

Merged

6 tasks

snider-nokia pushed a commit to snider-nokia/sonic-buildimage that referenced this pull request Apr 6, 2023

Fix RegGroupField decode (sonic-net#245)

9cea07f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build python3.6 deb packages and install them into docker-snmp-sv2 #245

Build python3.6 deb packages and install them into docker-snmp-sv2 #245

qiluo-msft commented Feb 3, 2017

lguohan Feb 3, 2017 •

edited by qiluo-msft

Loading

stcheng Feb 4, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Feb 6, 2017

stcheng Feb 4, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Feb 6, 2017

jleveque Feb 6, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Feb 7, 2017

lguohan Feb 7, 2017 •

edited

Loading

stcheng Feb 4, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Feb 6, 2017

stcheng Feb 6, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Feb 7, 2017

lguohan Feb 7, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Feb 8, 2017

stcheng left a comment

lguohan commented Feb 8, 2017 •

edited by qiluo-msft

Loading

lguohan Feb 8, 2017 •

edited by qiluo-msft

Loading

lguohan Feb 8, 2017 •

edited by qiluo-msft

Loading

lguohan Feb 8, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Feb 8, 2017

lguohan left a comment

stcheng commented Feb 9, 2017

lguohan commented Feb 9, 2017

Build python3.6 deb packages and install them into docker-snmp-sv2 #245

Build python3.6 deb packages and install them into docker-snmp-sv2 #245

Conversation

qiluo-msft commented Feb 3, 2017

lguohan Feb 3, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

stcheng Feb 4, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Feb 6, 2017

Choose a reason for hiding this comment

stcheng Feb 4, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Feb 6, 2017

Choose a reason for hiding this comment

jleveque Feb 6, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Feb 7, 2017

Choose a reason for hiding this comment

lguohan Feb 7, 2017 • edited Loading

Choose a reason for hiding this comment

stcheng Feb 4, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Feb 6, 2017

Choose a reason for hiding this comment

stcheng Feb 6, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Feb 7, 2017

Choose a reason for hiding this comment

lguohan Feb 7, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Feb 8, 2017

Choose a reason for hiding this comment

stcheng left a comment

Choose a reason for hiding this comment

lguohan commented Feb 8, 2017 • edited by qiluo-msft Loading

lguohan Feb 8, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

lguohan Feb 8, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

lguohan Feb 8, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Feb 8, 2017

Choose a reason for hiding this comment

lguohan left a comment

Choose a reason for hiding this comment

stcheng commented Feb 9, 2017

lguohan commented Feb 9, 2017

lguohan Feb 3, 2017 •

edited by qiluo-msft

Loading

stcheng Feb 4, 2017 •

edited by qiluo-msft

Loading

stcheng Feb 4, 2017 •

edited by qiluo-msft

Loading

jleveque Feb 6, 2017 •

edited by qiluo-msft

Loading

lguohan Feb 7, 2017 •

edited

Loading

stcheng Feb 4, 2017 •

edited by qiluo-msft

Loading

stcheng Feb 6, 2017 •

edited by qiluo-msft

Loading

lguohan Feb 7, 2017 •

edited by qiluo-msft

Loading

lguohan commented Feb 8, 2017 •

edited by qiluo-msft

Loading

lguohan Feb 8, 2017 •

edited by qiluo-msft

Loading

lguohan Feb 8, 2017 •

edited by qiluo-msft

Loading

lguohan Feb 8, 2017 •

edited by qiluo-msft

Loading