Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial changes for dhcp to support eth0 in a mgmt vrf #2348

Merged
merged 9 commits into from
Jan 16, 2019
Merged

Initial changes for dhcp to support eth0 in a mgmt vrf #2348

merged 9 commits into from
Jan 16, 2019

Conversation

nikos-github
Copy link
Collaborator

@nikos-github nikos-github commented Dec 5, 2018 •
edited
Loading

The current changes are a no-op without putting eth0 in a vrf.

With the changes, eth0 can be placed in a vrf and on startup it will get an IP address via dhcp. IP address changes or gateway changes are correctly reflected.

Next to figure out is dns and ntp.

Nikos.-

Signed-off-by: nikos [email protected]

@nikos-github nikos-github changed the title Initial changes to support eth0 in a mgmt vrf Initial changes for dhcp to support eth0 in a mgmt vrf Dec 5, 2018
lguohan
lguohan reviewed Dec 5, 2018
View reviewed changes
files/dhcp/vrf Show resolved Hide resolved
@lguohan
Copy link
Collaborator

lguohan commented Dec 5, 2018

there is broadcom build failure, i suspect it is related ifupdown2.

@nikos-github
Copy link
Collaborator Author

retest this please

@nikos-github
Copy link
Collaborator Author

retest this please

@nikos-github
Copy link
Collaborator Author

@lguohan Can we please merge this?

@nikos-github nikos-github mentioned this pull request Jan 7, 2019
Closed
@lguohan
Copy link
Collaborator

lguohan commented Jan 8, 2019

@nikos-github, since you did not delete the script rfc3442-classless-routes, and they both add routes, is there going to be some conflict here?

@lguohan
Copy link
Collaborator

lguohan commented Jan 8, 2019

there is no comment for the vrf script, can you provide description?

lguohan
lguohan reviewed Jan 8, 2019
View reviewed changes
files/dhcp/vrf Show resolved Hide resolved
lguohan
lguohan reviewed Jan 8, 2019
View reviewed changes
files/dhcp/vrf Show resolved Hide resolved
@nikos-github
Copy link
Collaborator Author

My bad - missed your comment about the description. Will add that.

@nikos-github
Copy link
Collaborator Author

@nikos-github, since you did not delete the script rfc3442-classless-routes, and they both add routes, is there going to be some conflict here?

There should be no conflict here since the table_id is checked.

@nikos-github
Copy link
Collaborator Author

@lguohan Description added.

@lguohan lguohan merged commit e55a7d7 into sonic-net:master Jan 16, 2019
@nikos-github nikos-github deleted the mgmt-vrf branch January 16, 2019 17:24
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this pull request Jun 24, 2022
@vivekrnv
[submodule]update sonic-swss submodule
be4d79b 
93af69c [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304)
37349cf [swssconfig] Optimize performance of swssconfig (sonic-net#2336)
84e9b07 [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353)
1b8bd94 Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351)
1ed0b4b [macsec] Refactor the logic of macsec name map (sonic-net#2348)
f88f992 [mock_tests] Add Sflow Orch UTs (sonic-net#2295)
ec57bf1 [macsec] Update macsec flex counter (sonic-net#2338)
6e0fc85 [ACL] Support stage particular match fields (sonic-net#2341)
efb4530 [orchagent, DTel]: report session support to set user vrf (sonic-net#2326)
d82874d Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig sonic-net#11046" (sonic-net#2332)
0c789e6 Fix qos map test in vs test (sonic-net#2343)
1bb5070 Enhance mock test for dynamic buffer manager for port removing and qos reload flows (sonic-net#2262)
700492f [aclorch] Fix and simplify DTel watchlist tables and entries (sonic-net#2155)

Signed-off-by: Vivek Reddy Karri <[email protected]>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jun 25, 2022
@yxieca
[202205][swss][swss-common][linkmgrd] advance submodule head
945fc15 
swss:
* ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R]
* ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox]
* d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk]
* 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K]
* 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai]
* 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai]

swss-common:
* 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation  (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai]
* c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai]

utilities:
* 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout  (sonic-net#2230) (github/202205) [Vivek R]

linkmgrd:
* 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang]

Signed-off-by: Ying Xie <[email protected]>
@yxieca yxieca mentioned this pull request Jun 25, 2022
Merged
yxieca added a commit that referenced this pull request Jun 27, 2022
@yxieca
[202205][swss][swss-common][linkmgrd] advance submodule head (#11254)
ae66e14 
swss:
* ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (#2304) (HEAD -> 202205) [Vivek R]
* ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (#2336) [Junchao-Mellanox]
* d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (#2353) [Yakiv Huryk]
* 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions #11235 (#2351) [Ravindranath C K]
* 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (#2348) [Junhua Zhai]
* 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (#2338) (HEAD -> 202205, github/202205) [Junhua Zhai]

swss-common:
* 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation  (#632) (HEAD -> 202205, github/202205) [Junhua Zhai]
* c21c47e 2022-06-14 | [counter] Add counter table (#622) [Junhua Zhai]

utilities:
* 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout  (#2230) (github/202205) [Vivek R]

linkmgrd:
* 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (#90) (HEAD -> 202205) [Jing Zhang]

Signed-off-by: Ying Xie <[email protected]>
prsunny pushed a commit that referenced this pull request Jun 28, 2022
@vivekrnv
[submodule]update sonic-swss submodule (#11253)
8dbfb0a 
Swss commits:

93af69c [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (#2304)
37349cf [swssconfig] Optimize performance of swssconfig (#2336)
84e9b07 [fdborch] fix heap-use-after-free in clearFdbEntry() (#2353)
1b8bd94 Create ACL table fails due to incorrect check for supported ACL actions #11235 (#2351)
1ed0b4b [macsec] Refactor the logic of macsec name map (#2348)
f88f992 [mock_tests] Add Sflow Orch UTs (#2295)
ec57bf1 [macsec] Update macsec flex counter (#2338)
6e0fc85 [ACL] Support stage particular match fields (#2341)
efb4530 [orchagent, DTel]: report session support to set user vrf (#2326)
d82874d Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig #11046" (#2332)
0c789e6 Fix qos map test in vs test (#2343)
1bb5070 Enhance mock test for dynamic buffer manager for port removing and qos reload flows (#2262)
700492f [aclorch] Fix and simplify DTel watchlist tables and entries (#2155)

Signed-off-by: Vivek Reddy Karri <[email protected]>
robertvolkmann pushed a commit to robertvolkmann/sonic-buildimage that referenced this pull request Jul 26, 2022
@yxieca @robertvolkmann
[202205][swss][swss-common][linkmgrd] advance submodule head (sonic-n…
5cf0399 
…et#11254)

swss:
* ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R]
* ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox]
* d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk]
* 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K]
* 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai]
* 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai]

swss-common:
* 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation  (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai]
* c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai]

utilities:
* 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout  (sonic-net#2230) (github/202205) [Vivek R]

linkmgrd:
* 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang]

Signed-off-by: Ying Xie <[email protected]>
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
@yxieca @skbarista
[202205][swss][swss-common][linkmgrd] advance submodule head (sonic-n…
3e02fa7 
…et#11254)

swss:
* ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R]
* ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox]
* d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk]
* 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K]
* 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai]
* 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai]

swss-common:
* 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation  (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai]
* c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai]

utilities:
* 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout  (sonic-net#2230) (github/202205) [Vivek R]

linkmgrd:
* 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang]

Signed-off-by: Ying Xie <[email protected]>
vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Aug 26, 2022
@jimmyzhai
[macsec] Refactor the logic of macsec name map (sonic-net#2348)
1ed0b4b 
* Add/remove macsec name map w/o gearbox correctly
* Add macsec counter unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svc-acs svc-acs svc-acs approved these changes

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikos-github @lguohan @svc-acs @stcheng