Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bcm SAI] enable Broadcom SAI 3.3 GA release #2329

Merged
merged 11 commits into from
Dec 2, 2018
Merged

[bcm SAI] enable Broadcom SAI 3.3 GA release #2329

merged 11 commits into from
Dec 2, 2018

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Dec 1, 2018

- What I did
Upgrade Broadcom SAI to 3.3 GA release.

- How to verify it
Passed nightly tests.

@yxieca
[saibcm] update saibcm kernel module source code to 6.5.13
73d4c99 
This is upgrading code as-is. The build will fail.

Signed-off-by: Ying Xie <[email protected]>
@yxieca
[broadcom patch] take Broadcom patch sdk-6.5.13-gpl-modules.patch
c50d4c2 
Signed-off-by: Ying Xie <[email protected]>
@yxieca
[saibcm] Fix make file and source code to build on kernel 4.9
ee65e7f 
The build passes under the name opennsl.

Signed-off-by: Ying Xie <[email protected]>
@yxieca
[libsaibcm modules] enabling building linux-knet-cb.ko
c22aca6 
Signed-off-by: Ying Xie <[email protected]>
@yxieca
[make file] add missing CFLAGS
936ca8d 
Signed-off-by: Ying Xie <[email protected]>
@yxieca
[SAI 3.3] update init script according to 3.3 requirement
243767c 
- Insert/remove linux-knet-cb module
- Create/remove devices for kernel modules

Signed-off-by: Ying Xie <[email protected]>
@yxieca
[Broadom driver] mute chatty debug information
5b3e897 
Signed-off-by: Ying Xie <[email protected]>
@yxieca
[opennsl init] refactoring opennsl init script
a11c28d 
- Move driver loading unloading code to functions.
- Change tabs to white spaces

Signed-off-by: Ying Xie <[email protected]>
@yxieca
[knet driver] fix PCI device init race condition
560d35b 
Broadcom CS5982299 fix.

Signed-off-by: Ying Xie <[email protected]>
@yxieca
[knet] Pick up some Broadcom knet driver changes in 3.3 GA release
550a45c 
Signed-off-by: Ying Xie <[email protected]>
@yxieca
[bcm sai] upgrade to Broadcom SAI 3.3 GA release
1812d6c 
Signed-off-by: Ying Xie <[email protected]>
@yxieca yxieca requested a review from lguohan December 1, 2018 17:34
@jipanyang
Copy link
Collaborator

It looks you put a few fixes to the broadcom openNsl code. Excluding the debian build part, is there any delta from the official openNsl 6.5.13 release? If there are any, could you point them out? thanks.

@yxieca
Copy link
Contributor Author

yxieca commented Dec 2, 2018 •
edited
Loading

Jipan,

I organized the commits to show the history of the changes:

  • The first commit is the official released gpl driver source code from Broadcom.
  • The next few changes are make file changes to make the build work.
  • There are a couple minor service file changes according to the 3.3 release notes.
  • The rest of the driver changes are all from Broadcom addressing various issues, referencing CSP numbers.
  • SAI 3.3 no longer requires opennsl. It is built directly on top of the SDK. I didn't change the debian package name for continuation. There are some components currently referencing this module name.

So all the 'diffs' are in this PR.

Regards,
Ying

@yxieca
Copy link
Contributor Author

yxieca commented Dec 2, 2018

NOTE: please rebase and merge this PR. Do NOT squash and merge. Please keep the git history.

lguohan
lguohan approved these changes Dec 2, 2018
View reviewed changes
Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lguohan lguohan merged commit 5d78dd0 into sonic-net:master Dec 2, 2018
@yxieca yxieca deleted the pub-3.3 branch December 4, 2018 23:24
@StormLiangMS StormLiangMS mentioned this pull request Jun 14, 2022
Merged
6 tasks
yxieca pushed a commit that referenced this pull request Jun 16, 2022
@StormLiangMS
[202205] [submodule] Advanced sonic-swss (#11137)
a4c8290 
submodule advance
Commit included:

54a9828 - (HEAD, public/202205) Combine PGs in buffermgrd (#2281) (#2329) (6 minutes ago)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcheng stcheng stcheng approved these changes

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Platform: Broadcom Submodule Update ⏫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yxieca @jipanyang @lguohan @stcheng @pollyhsu2git