Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build image] copy init_interfaces to interfaces #2302

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Nov 26, 2018

Signed-off-by: Ying Xie [email protected]

- What I did
init_interfaces meant to be sonic init interfaces configuration file.
However, it needs to be copied to the right file name to take effect.

init_interfaces meant to be sonic init interfaces configuration file.
However, it needs to be copied to the right file name to take effect.

Signed-off-by: Ying Xie <[email protected]>
@yxieca yxieca requested a review from taoyl-ms November 26, 2018 16:45
@stcheng
Copy link
Contributor

stcheng commented Nov 26, 2018

What about the current interfaces.j2 file? Any conflicts?

@yxieca
Copy link
Contributor Author

yxieca commented Nov 27, 2018

Not ready to merge yet. Though this change saved 60+ second in boot up time. The updategraph service didn't turn on dhcp on eth0 after boot up when minigraph is missing. This behavior might cause some unexpected behavior. This change should only be merged after updategraph service can turn on dhcp client on eth0.

@yxieca
Copy link
Contributor Author

yxieca commented Nov 27, 2018

Never mind. It is my next change needs matching update graph service change. not this one.

@yxieca yxieca merged commit ce60c53 into sonic-net:master Nov 27, 2018
@yxieca yxieca deleted the interfaces branch November 27, 2018 22:35
lguohan pushed a commit that referenced this pull request Jun 6, 2022
This PR is to advance sonic-swss submodule for 202012 branch.
Changes include

eef993f [202012][cherry-pick]Update orchagent to support new field pfcwd_sw_enable (#2302)
ab675b3 [202012][cherry-pick] Support tunnel traffic QoS remapping (#2246)

Signed-off-by: bingwang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants