[Mellanox] Update MFT to v4.9.0 #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Moroz <[email protected]>
stcheng
approved these changes
Nov 7, 2018
6 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Jul 28, 2022
feeac84 [counters] Keep counters cache in a single directory (#2232) cd7909e Updated the CLI file for Radius and Linux kernel commands (#2276) cd6898b Update db_migrator to support `PORT_QOS_MAP|global` (#2205) 8f4fc62 Revert "Revert "[scripts/fast-reboot] Shutdown remaining containers through systemd (#2133)" (#2161)" (#2184) 27667cf Fix test for pfcwd_sw_enable in db_migrator_test (#2253) e1866e3 [MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform (#2258) 9e3ba82 Change db_migrator major version on master branch from version 2 to 3 (#2272) 65346ce Microsoft mandatory file (#2177) 308e25f portconfig option to configure Tx power and laser frequency of ZR transceiver module (#2197) e49b1e8 [vnet_route_check] Align DB data parse logic with format used by swsscommon API (#2268) Signed-off-by: Stepan Blyschak <[email protected]>
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Aug 26, 2022
…nic-net#2232) **What I did** Fix the issue when *natmgrd* remains running after receiving SIGTERM signal and performing clean-up. **Why I did it** Supervisord sends SIGTERM to all applications that it controls. Application after receiving the signal may optionally run a clean-up routine and should exit. natmngrd runs a cleanup from the signal handler but doesn't exit after that. After supervisord sends the signal it waits for 10 seconds (default timeout) to allow the application to exit correctly. If the application is not exiting in the given timeout supervisord kills the application. natmngrd is always killed by the supervisord. This affects the container restart time. Before the fix NAT container shutting down takes ~10 seconds. Docker kills the application with SIGKILL signal after timeout: ``` # time /usr/bin/nat.sh stop real 0m10.420s user 0m0.227s sys 0m0.046s Apr 18 10:46:16.881285 r-leopard-32 INFO nat#supervisord 2022-04-18 10:46:16,879 WARN received SIGTERM indicating exit request Apr 18 10:46:16.881285 r-leopard-32 INFO nat#supervisord 2022-04-18 10:46:16,880 INFO waiting for supervisor-proc-exit-listener, rsyslogd, natmgrd, natsyncd to die Apr 18 10:46:17.883936 r-leopard-32 INFO nat#supervisord 2022-04-18 10:46:17,883 INFO stopped: natsyncd (terminated by SIGTERM) Apr 18 10:46:17.883936 r-leopard-32 NOTICE nat#natmgrd: :- sigterm_handler: Got SIGTERM Apr 18 10:46:17.891989 r-leopard-32 INFO nat#/supervisord: natmgrd conntrack v1.4.5 (conntrack-tools): connection tracking table has been emptied. Apr 18 10:46:17.891989 r-leopard-32 NOTICE nat#natmgrd: :- sigterm_handler: Sending notification to orchagent to cleanup NAT entries in REDIS/ASIC Apr 18 10:46:19.895501 r-leopard-32 INFO nat#supervisord 2022-04-18 10:46:19,894 INFO waiting for supervisor-proc-exit-listener, rsyslogd, natmgrd to die Apr 18 10:46:22.898947 r-leopard-32 INFO nat#supervisord 2022-04-18 10:46:22,898 INFO waiting for supervisor-proc-exit-listener, rsyslogd, natmgrd to die Apr 18 10:46:25.903148 r-leopard-32 INFO nat#supervisord 2022-04-18 10:46:25,902 INFO waiting for supervisor-proc-exit-listener, rsyslogd, natmgrd to die Apr 18 10:46:26.115147 r-leopard-32 INFO dockerd[737]: time="2022-04-18T10:46:26.114201315Z" level=info msg="Container ec5804a8ccd413786392c27ac3e61d4dfe67c8e5558c91b6c6bf0712cf85d07a failed to exit within 10 seconds of signal 15 - using the force" ``` After the fix NAT container shutting down takes ~4 seconds. The application exits correctly after receiving SIGTERM signal: ``` # time /usr/bin/nat.sh stop real 0m4.166s user 0m0.219s sys 0m0.036s Apr 18 10:52:23.611991 r-leopard-32 INFO nat#supervisord 2022-04-18 10:52:23,610 WARN received SIGTERM indicating exit request Apr 18 10:52:23.611991 r-leopard-32 INFO nat#supervisord 2022-04-18 10:52:23,610 INFO waiting for supervisor-proc-exit-listener, rsyslogd, natmgrd, natsyncd to die Apr 18 10:52:23.613338 r-leopard-32 INFO nat#supervisord 2022-04-18 10:52:23,612 INFO stopped: natsyncd (terminated by SIGTERM) Apr 18 10:52:24.620815 r-leopard-32 INFO nat#/supervisord: natmgrd conntrack v1.4.5 (conntrack-tools): connection tracking table has been emptied. Apr 18 10:52:24.620815 r-leopard-32 NOTICE nat#natmgrd: :- cleanup: Sending notification to orchagent to cleanup NAT entries in REDIS/ASIC Apr 18 10:52:25.407307 r-leopard-32 INFO nat#supervisord 2022-04-18 10:52:25,406 INFO stopped: natmgrd (exit status 0) ``` **How I verified it** Stop NAT container. Check syslog whether natmgrd application exited correctly with return code '0'.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz [email protected]
- What I did
Updated MFT version
- How I did it
Changed MFT version in the make file
- How to verify it
build SONiC, make sure MFT work (fw upgrade, link, cable, other utilities work)
- Description for the changelog