Adapt to the new WARM_RESTART_TABLE table schema: change from restart… #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Sep 26, 2018
| @@ -47,7 +47,7 @@ SYSTEM_WARM_START=`redis-cli -n 4 hget "WARM_RESTART|system" enable` | |||
| SWSS_WARM_START=`redis-cli -n 4 hget "WARM_RESTART|swss" enable` | |||
| if [[ "$SYSTEM_WARM_START" == "true" ]] || [[ "$SWSS_WARM_START" == "true" ]]; then | |||
| # We have to make sure db data has not been flushed. | |||
| RESTART_COUNT=`redis-cli -n 6 hget "WARM_RESTART_TABLE|orchagent" restart_count` | |||
| RESTART_COUNT=`redis-cli -n 6 hget "WARM_RESTART_TABLE|orchagent" restore_count` | |||
There was a problem hiding this comment.
do you also need to change the variable name here?
|
also can you update the sonic-swss repo. |
…_count to restore_count Signed-off-by: Jipan Yang <[email protected]>
Signed-off-by: Jipan Yang <[email protected]>
Signed-off-by: Jipan Yang <[email protected]>
jipanyang
force-pushed
the
restore_count
branch
from
15c724f
to
80d05fa
Compare
lguohan
approved these changes
Oct 2, 2018
abdosi
pushed a commit
that referenced
this pull request
Jan 21, 2022
Update the sonic-swss submodule. The following are new commits in the submodule: 6cb43ee [p4orch] Fix handlePortStatusChangeNotification status deserialize (#2111) 863f0f1 [azp]: Enable PR diff coverage (#2083) bf4cd4a Fix the unsafe usage of strncpy in portsorch.cpp (#2110) c1b4b40 support port isolation group in BFN platform (#1940) Signed-off-by: Andriy Kokhan <[email protected]>
theasianpianist
added a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
- Setup AZP builds to enforce PR code diff coverage limits - Current limit is at 0%, to be adjusted to actual value in a future PR Signed-off-by: Lawrence Lee <[email protected]>
6 tasks
wen587
added a commit
that referenced
this pull request
Mar 8, 2022
47c243e [show][muxcable] fix the sudo access error for show muxcable metrics (#2083) f872516 [muxcable][show] enhance show mux status to show last switchover time (#2067) d440df7 [warmboot] Migrate 10G ports during warm-reboot on s6100 (#2064) 494c6d7 [counterpoll] Display the correct default poll interval for watermark counters (#2082) 499988e [show][config] add muxcable command line support for retrieve / reset ICMP packet loss data (#2046) 8b01d3e Remove the warning message appear when there are no ports on CONFIG DB (#2050) ed6e66e [GCU] Supporting Groupings during path-xpath translation (#2044) 25b3455 [ci] Use official build debian pkg instead and parameterize source branch (#2079)
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
…onic-net#2083) This change is required for such behavior with the command below, which works okay if you try with sudo How to verify it with the change, no need for sudo, tested on an arista 7050cx3 lab device vdahiya@sonic:~$ show mux metrics Ethernet0 PORT EVENT TIME --------- ---------------------------- --------------------------- Ethernet0 linkmgrd_switch_active_start 2022-Feb-28 18:49:59.350302 Ethernet0 xcvrd_switch_active_start 2022-Feb-28 18:49:59.354076 Ethernet0 xcvrd_switch_active_end 2022-Feb-28 18:49:59.357925 Ethernet0 linkmgrd_switch_active_end 2022-Feb-28 18:49:59.35919 Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_count to restore_count
Signed-off-by: Jipan Yang [email protected]
- What I did
With changes introduced in sonic-net/sonic-swss#600
WARM_RESTART_TABLE:restart_count got changed to WARM_RESTART_TABLE:restore_count
The swss related check for WARM_RESTART_TABLE:restart_count should be updated.
- How I did it
- How to verify it
docker upgrade and systemctl restart.
Don't merge the change until swss submodule updated