[Mellanox] Enable get_rx_los API support in CMIS cable host mgmt mode #20743

mihirpat1 · 2024-11-08T21:46:32Z

Why I did it

The show int transceiver status PORT CLI always displays Rx LOS as False for all the lanes.

root@sonic:/home/admin# show int transceiver status Ethernet0 | grep "Rx loss"
        Rx loss of signal flag on media lane 1: False
        Rx loss of signal flag on media lane 2: False
        Rx loss of signal flag on media lane 3: False
        Rx loss of signal flag on media lane 4: False
        Rx loss of signal flag on media lane 5: False
        Rx loss of signal flag on media lane 6: False
        Rx loss of signal flag on media lane 7: False
        Rx loss of signal flag on media lane 8: False
root@sonic:/home/admin#

Work item tracking

Microsoft ADO (number only): 30180403

How I did it

On Mellanox platforms, the get_rx_los API is overridden through the platform implementation (

sonic-buildimage/platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py

Line 1069 in 6799976

def get_rx_los(self):

) rather than using the implementation defined through cmis.py (https://github.com/sonic-net/sonic-platform-common/blob/59babf59f9aa611b84082896391b01a39ffcb866/sonic_platform_base/sonic_xcvr/api/public/cmis.py#L404).

The Mellanox platform is overriding the get_rx_los due to the below code

sonic-buildimage/platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py

Lines 1188 to 1189 in 6799976

    
           if self._xcvr_api is not None: 
        
               self._xcvr_api.get_rx_los = self.get_rx_los

The current platform implementation assigns Rx LOS as False for all the lanes (irrespective of the actual status on the module) which in turn causes the show int transceiver status PORT CLI to display the Rx LOS as False for all the lanes.

Hence, removing the overriding part to ensure that the API is not overridden by the platform.

How to verify it

Verified the CLI on first 2 lanes which are in admin disabled state from the peer side.

root@sonic:/home/admin# show int transceiver status Ethernet0 | grep "Rx loss"
        Rx loss of signal flag on media lane 1: False
        Rx loss of signal flag on media lane 2: False
        Rx loss of signal flag on media lane 3: True
        Rx loss of signal flag on media lane 4: True
        Rx loss of signal flag on media lane 5: True
        Rx loss of signal flag on media lane 6: True
        Rx loss of signal flag on media lane 7: True
        Rx loss of signal flag on media lane 8: True
root@sonic:/home/admin#

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Mihir Patel <[email protected]>

prgeor · 2024-11-08T21:50:39Z

@liat-grozovik @Junchao-Mellanox can you also review

keboliu

There is a limitation on the Mellanox platform to support RX LOS reading in FW control mode, this change will also enable the RX LOS reading in FW control mode, we should have a logic to differentiate between FW control mode and host mgmt mode. @Junchao-Mellanox

Junchao-Mellanox · 2024-11-11T03:19:08Z

There is a limitation on the Mellanox platform to support RX LOS reading in FW control mode, this change will also enable the RX LOS reading in FW control mode, we should have a logic to differentiate between FW control mode and host mgmt mode. @Junchao-Mellanox

Thanks for catching this. Indeed, we need do something like following:

def get_rx_los(self):
        """Accessing rx los is not supproted, return all False

        Returns:
            list: [False] * channels
        """
        api = self.get_xcvr_api()
        if self.is_sw_control():
                return api.get_rx_los()
        return [False] * api.NUM_CHANNELS if api else None

mihirpat1 · 2024-11-11T06:16:08Z

we should have a logic to differentiate between FW control mode and host mgmt mode. @Junchao-Mellanox

@Junchao-Mellanox @keboliu I have now addressed this. Can you please help in reviewing it?

mihirpat1 · 2024-11-13T07:27:44Z

@liat-grozovik Can you please help in merging this PR?

mihirpat1 · 2024-11-13T21:40:55Z

@bingwang-ms @yxieca Can you please help in merging this to 202405 and 202311?
MSFT ADO - 30180403

…sonic-net#20743) - Why I did it The show int transceiver status PORT CLI always displays Rx LOS as False for all the lanes. - How I did it The current platform implementation assigns Rx LOS as False for all the lanes (irrespective of the actual status on the module) which in turn causes the show int transceiver status PORT CLI to display the Rx LOS as False for all the lanes. Hence, removing the overriding part to ensure that the API is not overridden by the platform. - How to verify it Verified the CLI on first 2 lanes which are in admin disabled state from the peer side. --------- Signed-off-by: Mihir Patel <[email protected]>

mssonicbld · 2024-11-13T21:48:08Z

Cherry-pick PR to 202405: #20790

…#20743) - Why I did it The show int transceiver status PORT CLI always displays Rx LOS as False for all the lanes. - How I did it The current platform implementation assigns Rx LOS as False for all the lanes (irrespective of the actual status on the module) which in turn causes the show int transceiver status PORT CLI to display the Rx LOS as False for all the lanes. Hence, removing the overriding part to ensure that the API is not overridden by the platform. - How to verify it Verified the CLI on first 2 lanes which are in admin disabled state from the peer side. --------- Signed-off-by: Mihir Patel <[email protected]>

…sonic-net#20743) - Why I did it The show int transceiver status PORT CLI always displays Rx LOS as False for all the lanes. - How I did it The current platform implementation assigns Rx LOS as False for all the lanes (irrespective of the actual status on the module) which in turn causes the show int transceiver status PORT CLI to display the Rx LOS as False for all the lanes. Hence, removing the overriding part to ensure that the API is not overridden by the platform. - How to verify it Verified the CLI on first 2 lanes which are in admin disabled state from the peer side. --------- Signed-off-by: Mihir Patel <[email protected]>

mssonicbld · 2024-11-14T17:53:12Z

Cherry-pick PR to 202311: #20805

…#20743) - Why I did it The show int transceiver status PORT CLI always displays Rx LOS as False for all the lanes. - How I did it The current platform implementation assigns Rx LOS as False for all the lanes (irrespective of the actual status on the module) which in turn causes the show int transceiver status PORT CLI to display the Rx LOS as False for all the lanes. Hence, removing the overriding part to ensure that the API is not overridden by the platform. - How to verify it Verified the CLI on first 2 lanes which are in admin disabled state from the peer side. --------- Signed-off-by: Mihir Patel <[email protected]>

…sonic-net#20743) - Why I did it The show int transceiver status PORT CLI always displays Rx LOS as False for all the lanes. - How I did it The current platform implementation assigns Rx LOS as False for all the lanes (irrespective of the actual status on the module) which in turn causes the show int transceiver status PORT CLI to display the Rx LOS as False for all the lanes. Hence, removing the overriding part to ensure that the API is not overridden by the platform. - How to verify it Verified the CLI on first 2 lanes which are in admin disabled state from the peer side. --------- Signed-off-by: Mihir Patel <[email protected]>

[Mellanox] Enable get_rx_los API support in CMIS cable host mgmt mode

c3400da

Signed-off-by: Mihir Patel <[email protected]>

mihirpat1 requested a review from lguohan as a code owner November 8, 2024 21:46

mihirpat1 requested review from prgeor and Junchao-Mellanox November 8, 2024 21:46

prgeor previously approved these changes Nov 8, 2024

View reviewed changes

mihirpat1 added the Request for 202405 Branch label Nov 8, 2024

prgeor added Included in 202311 Branch Platform: Mellanox labels Nov 8, 2024

Junchao-Mellanox approved these changes Nov 11, 2024

View reviewed changes

keboliu suggested changes Nov 11, 2024

View reviewed changes

Added support for FW control mode

e6dd1d1

mihirpat1 dismissed prgeor’s stale review via e6dd1d1 November 11, 2024 06:13

Junchao-Mellanox approved these changes Nov 11, 2024

View reviewed changes

keboliu approved these changes Nov 13, 2024

View reviewed changes

mihirpat1 added Request for 202311 Branch and removed Included in 202311 Branch labels Nov 13, 2024

prgeor approved these changes Nov 13, 2024

View reviewed changes

liat-grozovik merged commit 8dd1d98 into sonic-net:master Nov 13, 2024
12 checks passed

bingwang-ms added the Approved for 202405 Branch label Nov 13, 2024

mssonicbld mentioned this pull request Nov 13, 2024

[action] [PR:20743] [Mellanox] Enable get_rx_los API support in CMIS cable host mgmt mode (#20743) #20790

Merged

mssonicbld added the Created PR to 202405 Branch label Nov 13, 2024

mssonicbld removed the Created PR to 202405 Branch label Nov 14, 2024

mssonicbld added the Included in 202405 Branch label Nov 14, 2024

yxieca added the Approved for 202311 Branch label Nov 14, 2024

mssonicbld mentioned this pull request Nov 14, 2024

[action] [PR:20743] [Mellanox] Enable get_rx_los API support in CMIS cable host mgmt mode (#20743) #20805

Merged

mssonicbld added the Created PR to 202311 Branch label Nov 14, 2024

mssonicbld added Included in 202311 Branch and removed Created PR to 202311 Branch labels Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mellanox] Enable get_rx_los API support in CMIS cable host mgmt mode #20743

[Mellanox] Enable get_rx_los API support in CMIS cable host mgmt mode #20743

mihirpat1 commented Nov 8, 2024 •

edited

Loading

prgeor commented Nov 8, 2024

keboliu left a comment

Junchao-Mellanox commented Nov 11, 2024

mihirpat1 commented Nov 11, 2024

mihirpat1 commented Nov 13, 2024

mihirpat1 commented Nov 13, 2024

mssonicbld commented Nov 13, 2024

mssonicbld commented Nov 14, 2024

	if self._xcvr_api is not None:
	self._xcvr_api.get_rx_los = self.get_rx_los

[Mellanox] Enable get_rx_los API support in CMIS cable host mgmt mode #20743

[Mellanox] Enable get_rx_los API support in CMIS cable host mgmt mode #20743

Conversation

mihirpat1 commented Nov 8, 2024 • edited Loading

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

prgeor commented Nov 8, 2024

keboliu left a comment

Choose a reason for hiding this comment

Junchao-Mellanox commented Nov 11, 2024

mihirpat1 commented Nov 11, 2024

mihirpat1 commented Nov 13, 2024

mihirpat1 commented Nov 13, 2024

mssonicbld commented Nov 13, 2024

mssonicbld commented Nov 14, 2024

mihirpat1 commented Nov 8, 2024 •

edited

Loading