[finalize-warmboot.sh] reset cpufreq governor to default #19634

stepanblyschak · 2024-07-19T07:12:25Z

Why I did it

Set cpufreq.default_governor to performance for faster boot time. We observe consistent 1 sec improvement across several devices.

The change in finalize-warmboot.sh restores the default governor after fast or warm boot is finished.

NOTE: This will apply to upgrades starting from 202405 since this is set in shutdown path to avoid any extra scripts running at boot time. Upgrade from older versions/branches will require a runtime patch to fast-reboot and warm-reboot script.

Work item tracking

Microsoft ADO (number only):

How I did it

After fast or warm boot is finished restore to default governor.

How to verify it

Run fast-reboot or warm-reboot. Check:

admin@sonic:~$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
performance

After boot is finalized check that it is reset back to default:

admin@sonic:~$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
schedutil

Tested with sonic-net/sonic-utilities#3435

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stepan Blyschak <[email protected]>

bingwang-ms · 2024-08-26T21:53:33Z

@saiarcot895 @vaibhavhd Can you please help review?

liat-grozovik · 2024-09-03T08:23:11Z

@vaibhavhd kindly reminder for code review feedback/approval.

vaibhavhd · 2024-09-09T16:18:47Z

Comments are open on utilities PR.

vaibhavhd · 2024-09-23T16:34:06Z

files/image_config/warmboot-finalizer/finalize-warmboot.sh

@@ -101,16 +101,30 @@ function check_list()
    echo ${RET_LIST}
 }

+function set_cpufreq_governor() {
+    local -r governor="$1"
+    echo "$governor" | tee /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor 1> /dev/null \


Will this setting (or the way we are writing to a file) be effective at runtime?

vaibhavhd · 2024-09-23T16:36:02Z

files/image_config/warmboot-finalizer/finalize-warmboot.sh

+
+function finalize_common() {
+    # Read default governor from kernel config
+    local -r default_governor=$(cat "/boot/config-$(uname -r)" | grep -o 'CONFIG_CPU_FREQ_DEFAULT_GOV_[^=]*=y')


What's the guarantee that "/boot/config-$(uname -r)" will have the default governor setting?

Do you need to sanity check on the value and type of default_governor here? What if the cat or grep result in a failure? Wouldn't the code proceed to assign invalid value to /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor

It's part of our sonic linux kernel config, why would we remove it or set it to invalid value?

vaibhavhd · 2024-10-14T16:07:10Z

files/image_config/warmboot-finalizer/finalize-warmboot.sh

+function finalize_common() {
+    # Read default governor from kernel config
+    local -r default_governor=$(cat "/boot/config-$(uname -r)" | grep -o 'CONFIG_CPU_FREQ_DEFAULT_GOV_[^=]*=y')
+    set_cpufreq_governor "$default_governor"


The utilities change is made for MLNX platforms only. I think it would be best to make this call only for MLNX platforms as well.

Thanks @vaibhavhd I applied your suggestion. While testing that modification found that the | grep is incorrect causing governor to not reset to default. That bug was introduced in "Handle review comments" commit, don't remember why I did it, but I reverted to previous default governor parsing method.

vaibhavhd

Approved with suggestions.

Signed-off-by: Stepan Blyschak <[email protected]>

stepanblyschak · 2024-10-16T10:25:05Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2024-10-16T10:25:08Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-10-16T10:25:21Z

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan · 2024-11-04T17:45:12Z

@qiluo-msft can you please help merge?

…9634) #### Why I did it Set cpufreq.default_governor to *performance* for faster boot time. We observe consistent 1 sec improvement across several devices. The change in finalize-warmboot.sh restores the default governor after fast or warm boot is finished. **NOTE**: This will apply to upgrades starting from 202405 since this is set in shutdown path to avoid any extra scripts running at boot time. Upgrade from older versions/branches will require a runtime patch to fast-reboot and warm-reboot script. #### How I did it After fast or warm boot is finished restore to default governor. #### How to verify it Run fast-reboot or warm-reboot. Check: ``` admin@sonic:~$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor performance ``` After boot is finalized check that it is reset back to default: ``` admin@sonic:~$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor schedutil ``` Tested with sonic-net/sonic-utilities#3435

bingwang-ms · 2024-12-04T17:46:02Z

@stepanblyschak Can you raise a PR to 202405 to do the cherry-pick? The auto cherry-pick is not working for this PR.

…9634) #### Why I did it Set cpufreq.default_governor to *performance* for faster boot time. We observe consistent 1 sec improvement across several devices. The change in finalize-warmboot.sh restores the default governor after fast or warm boot is finished. **NOTE**: This will apply to upgrades starting from 202405 since this is set in shutdown path to avoid any extra scripts running at boot time. Upgrade from older versions/branches will require a runtime patch to fast-reboot and warm-reboot script. #### How I did it After fast or warm boot is finished restore to default governor. #### How to verify it Run fast-reboot or warm-reboot. Check: ``` admin@sonic:~$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor performance ``` After boot is finalized check that it is reset back to default: ``` admin@sonic:~$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor schedutil ``` Tested with sonic-net/sonic-utilities#3435

mssonicbld · 2024-12-04T18:04:22Z

Cherry-pick PR to 202405: #21030

#### Why I did it Set cpufreq.default_governor to *performance* for faster boot time. We observe consistent 1 sec improvement across several devices. The change in finalize-warmboot.sh restores the default governor after fast or warm boot is finished. **NOTE**: This will apply to upgrades starting from 202405 since this is set in shutdown path to avoid any extra scripts running at boot time. Upgrade from older versions/branches will require a runtime patch to fast-reboot and warm-reboot script. #### How I did it After fast or warm boot is finished restore to default governor. #### How to verify it Run fast-reboot or warm-reboot. Check: ``` admin@sonic:~$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor performance ``` After boot is finalized check that it is reset back to default: ``` admin@sonic:~$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor schedutil ``` Tested with sonic-net/sonic-utilities#3435

stepanblyschak added 2 commits July 18, 2024 10:10

[finalize-warmboot.sh] reset cpufreq governor to default

51ef6a2

Signed-off-by: Stepan Blyschak <[email protected]>

Handle review comments

d53703e

Signed-off-by: Stepan Blyschak <[email protected]>

stepanblyschak requested a review from lguohan as a code owner July 19, 2024 07:12

stepanblyschak mentioned this pull request Jul 19, 2024

[fast/warm-reboot] add cpufreq.default_governor=performance to BOOT_OPTIONS sonic-net/sonic-utilities#3435

Merged

yxieca requested review from saiarcot895 and vaibhavhd July 19, 2024 16:49

vaibhavhd reviewed Sep 23, 2024

View reviewed changes

vaibhavhd reviewed Oct 14, 2024

View reviewed changes

vaibhavhd approved these changes Oct 14, 2024

View reviewed changes

stepanblyschak added 2 commits October 15, 2024 12:55

set only on mellanox platform

21a6851

Signed-off-by: Stepan Blyschak <[email protected]>

fix grep

8aef814

Signed-off-by: Stepan Blyschak <[email protected]>

qiluo-msft approved these changes Nov 4, 2024

View reviewed changes

qiluo-msft merged commit 33000a5 into sonic-net:master Nov 4, 2024
23 checks passed

bingwang-ms added Request for 202405 Branch Approved for 202405 Branch labels Nov 4, 2024

bingwang-ms added Approved for 202405 Branch and removed Approved for 202405 Branch labels Dec 4, 2024

mssonicbld mentioned this pull request Dec 4, 2024

[action] [PR:19634] [finalize-warmboot.sh] reset cpufreq governor to default (#19634) #21030

Merged

mssonicbld added the Created PR to 202405 Branch label Dec 4, 2024

mssonicbld added Included in 202405 Branch and removed Created PR to 202405 Branch labels Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[finalize-warmboot.sh] reset cpufreq governor to default #19634

[finalize-warmboot.sh] reset cpufreq governor to default #19634

stepanblyschak commented Jul 19, 2024 •

edited

Loading

bingwang-ms commented Aug 26, 2024

liat-grozovik commented Sep 3, 2024

vaibhavhd commented Sep 9, 2024

vaibhavhd Sep 23, 2024

stepanblyschak Oct 4, 2024

vaibhavhd Sep 23, 2024

stepanblyschak Oct 4, 2024

vaibhavhd Oct 14, 2024

stepanblyschak Oct 15, 2024

vaibhavhd left a comment

stepanblyschak commented Oct 16, 2024

mssonicbld commented Oct 16, 2024

azure-pipelines bot commented Oct 16, 2024

dgsudharsan commented Nov 4, 2024

bingwang-ms commented Dec 4, 2024

mssonicbld commented Dec 4, 2024

[finalize-warmboot.sh] reset cpufreq governor to default #19634

[finalize-warmboot.sh] reset cpufreq governor to default #19634

Conversation

stepanblyschak commented Jul 19, 2024 • edited Loading

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

bingwang-ms commented Aug 26, 2024

liat-grozovik commented Sep 3, 2024

vaibhavhd commented Sep 9, 2024

vaibhavhd Sep 23, 2024

Choose a reason for hiding this comment

stepanblyschak Oct 4, 2024

Choose a reason for hiding this comment

vaibhavhd Sep 23, 2024

Choose a reason for hiding this comment

stepanblyschak Oct 4, 2024

Choose a reason for hiding this comment

vaibhavhd Oct 14, 2024

Choose a reason for hiding this comment

stepanblyschak Oct 15, 2024

Choose a reason for hiding this comment

vaibhavhd left a comment

Choose a reason for hiding this comment

stepanblyschak commented Oct 16, 2024

mssonicbld commented Oct 16, 2024

azure-pipelines bot commented Oct 16, 2024

dgsudharsan commented Nov 4, 2024

bingwang-ms commented Dec 4, 2024

mssonicbld commented Dec 4, 2024

stepanblyschak commented Jul 19, 2024 •

edited

Loading