Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 200G values to pg profile lookup #19342

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

ccroy-arista
Copy link
Contributor

This change adds 200G settings for Tomahawk 5 to the pg_profile_lookup.

Fixes: https://github.com/aristanetworks/sonic-qual.msft/issues/159

Why I did it

This change is needed in order for some qos tests to run against TH5.

How I did it

Added the values then manually ran qos tests identified in the issue above to verify fix.

How to verify it

Run qos/test_qos_sai.py::TestQosSai::testParameter and confirm that the IndexError in the issue above does not occur.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311
  • 202405

This change adds 200G settings for
Tomahawk 5 to the pg_profile_lookup.
@ccroy-arista ccroy-arista marked this pull request as ready for review June 18, 2024 19:04
Copy link
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bingwang-ms
Copy link
Contributor

/azp rerun

Copy link

Command 'rerun' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@bingwang-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit 898c42b into sonic-net:master Jun 25, 2024
19 of 20 checks passed
@ccroy-arista
Copy link
Contributor Author

202405 merge conflict is due to needing the following PR to be cherry-picked into 202405 first: #19161

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 25, 2024
This change adds 200G settings for Tomahawk 5 to the pg_profile_lookup.

Fixes: aristanetworks/sonic-qual.msft#159

Why I did it
This change is needed in order for some qos tests to run against TH5.

How I did it
Added the values then manually ran qos tests identified in the issue above to verify fix.

How to verify it
Run qos/test_qos_sai.py::TestQosSai::testParameter and confirm that the IndexError in the issue above does not occur.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #19392

yxieca pushed a commit that referenced this pull request Jun 26, 2024
This change adds 200G settings for Tomahawk 5 to the pg_profile_lookup.

Fixes: aristanetworks/sonic-qual.msft#159

Why I did it
This change is needed in order for some qos tests to run against TH5.

How I did it
Added the values then manually ran qos tests identified in the issue above to verify fix.

How to verify it
Run qos/test_qos_sai.py::TestQosSai::testParameter and confirm that the IndexError in the issue above does not occur.

Co-authored-by: Chris <[email protected]>
@ccroy-arista
Copy link
Contributor Author

Awaiting cherry-pick to 202405 for #19161

arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
This change adds 200G settings for Tomahawk 5 to the pg_profile_lookup.

Fixes: aristanetworks/sonic-qual.msft#159

Why I did it
This change is needed in order for some qos tests to run against TH5.

How I did it
Added the values then manually ran qos tests identified in the issue above to verify fix.

How to verify it
Run qos/test_qos_sai.py::TestQosSai::testParameter and confirm that the IndexError in the issue above does not occur.
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
This change adds 200G settings for Tomahawk 5 to the pg_profile_lookup.

Fixes: aristanetworks/sonic-qual.msft#159

Why I did it
This change is needed in order for some qos tests to run against TH5.

How I did it
Added the values then manually ran qos tests identified in the issue above to verify fix.

How to verify it
Run qos/test_qos_sai.py::TestQosSai::testParameter and confirm that the IndexError in the issue above does not occur.
@ccroy-arista
Copy link
Contributor Author

Awaiting cherry-pick to 202405.

1 similar comment
@ccroy-arista
Copy link
Contributor Author

Awaiting cherry-pick to 202405.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 19, 2024
This change adds 200G settings for Tomahawk 5 to the pg_profile_lookup.

Fixes: aristanetworks/sonic-qual.msft#159

Why I did it
This change is needed in order for some qos tests to run against TH5.

How I did it
Added the values then manually ran qos tests identified in the issue above to verify fix.

How to verify it
Run qos/test_qos_sai.py::TestQosSai::testParameter and confirm that the IndexError in the issue above does not occur.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #19956

mssonicbld pushed a commit that referenced this pull request Aug 20, 2024
This change adds 200G settings for Tomahawk 5 to the pg_profile_lookup.

Fixes: aristanetworks/sonic-qual.msft#159

Why I did it
This change is needed in order for some qos tests to run against TH5.

How I did it
Added the values then manually ran qos tests identified in the issue above to verify fix.

How to verify it
Run qos/test_qos_sai.py::TestQosSai::testParameter and confirm that the IndexError in the issue above does not occur.
@ccroy-arista ccroy-arista deleted the add-200g-pg-profile-th5-values branch November 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants